Change localhost port for cypress tests and document how its used #257
Conversation
| @@ -7,7 +7,7 @@ describe('Shepherd Acceptance Tests', () => { | |||
| beforeEach(() => { | |||
| Shepherd = null; | |||
|
|
|||
| cy.visit('http://localhost:8080/test/dummy/', { | |||
There was a problem hiding this comment.
I think we had to manually set this here, rather than using baseURL to make sure that things worked for both the demo app and the test app.
There was a problem hiding this comment.
I'm not sure I'm following. Do you mean running the demo app with yarn start? It doesn't seem like that would interfere with cy
There was a problem hiding this comment.
There was some reason we needed the full path before. I don't remember why.
There was a problem hiding this comment.
I think it was to support the demo app, what we deploy for the demo.
There was a problem hiding this comment.
We can merge and see if the demo still looks good
BrianSipple
force-pushed
the
fix-build
branch
from
a0682af to
0608f81
Compare
| "test:cy:ci": "yarn test:build && start-server-and-test start-test-server http://localhost:8080 cy:run", | ||
| "test:cy:watch": "start-server-and-test start-test-server http://localhost:8080 cy:open", | ||
| "test:cy:ci": "yarn test:build && start-server-and-test start-test-server http://localhost:9002 cy:run", | ||
| "test:cy:watch": "yarn test:build && start-server-and-test start-test-server http://localhost:9002 cy:open", |
There was a problem hiding this comment.
Do you think if we ran yarn watch here, instead of yarn test:build it would rebuild the assets? I think this was supposed to be live reloading, but not sure how it was supposed to work.
I still want to try and get acceptance tests working with live reloading, but in the meantime, I was able to make a few tweaks to the Cypress configuration and the way we're documenting it.