Allow exit animations to play before step tooltip disappears. #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianSipple
force-pushed
the
support-waiting-on-show
branch
2 times, most recently
from
9bb47bc
to
4c0a30a
Compare
BrianSipple
changed the title
BrianSipple
force-pushed
the
support-waiting-on-show
branch
2 times, most recently
from
8e4f85a
to
3283f4f
Compare
BrianSipple
changed the title
BrianSipple
force-pushed
the
support-waiting-on-show
branch
2 times, most recently
from
811a82f
to
7b02b46
Compare
Closes #277 This removes our own manual management of `this.el`'s appearance/presence in the DOM -- since tippy is handling it already.
BrianSipple
force-pushed
the
support-waiting-on-show
branch
3 times, most recently
from
aa69177
to
1a74ed0
Compare
BrianSipple
commented
Oct 18, 2018
There was a problem hiding this comment.
This got a bit harrier than I anticipated -- for a few reasons:
As I started testing the step cleanup process to account for the Step.hide changes, I realized that some of our unit test blocks weren't properly tearing down their Tour instance -- so that accounts for some of the structural changes.
I also moved the Step cleanup tests out of Cy and into Mocha to try and keep it as focused as possible. (I continue to have issues with Cy finding elements that "should not exist" because they did exist at some point during the test 😕).
Finally, I refactored done so that it calls destroy on the current step instead of hide, while also separating currentStep.hide outside the concern of Tour._setupActiveTour.
BrianSipple
commented
Oct 18, 2018
RobbieTheWagner
requested changes
Oct 18, 2018
BrianSipple
force-pushed
the
support-waiting-on-show
branch
2 times, most recently
from
8dba962
to
2cd8c07
Compare
BrianSipple
force-pushed
the
support-waiting-on-show
branch
from
2cd8c07
to
2f7e6a0
Compare
BrianSipple
force-pushed
the
support-waiting-on-show
branch
from
0fd8650
to
325b372
Compare
RobbieTheWagner
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #277
This removes our own manual management of
this.el's appearance/presencein the DOM -- since tippy is handling it already.
This allows the tooltip's exit animation to play, as opposed to having the element disappear instantly before we even call
tippy.hide.