Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move modal to its own class #308

Merged
merged 3 commits into from
Jan 6, 2019
Merged

Move modal to its own class #308

merged 3 commits into from
Jan 6, 2019

Conversation

RobbieTheWagner
Copy link
Member

I still need to write some tests, now that this is its own class, but wanted to get some eyes on it beforehand.

@BrianSipple
Copy link
Contributor

👍

@RobbieTheWagner RobbieTheWagner merged commit 29289af into master Jan 6, 2019
@RobbieTheWagner RobbieTheWagner deleted the refactor-modal branch January 6, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckcarpenter chuckcarpenter Awaiting requested review from chuckcarpenter

@BrianSipple BrianSipple Awaiting requested review from BrianSipple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobbieTheWagner @BrianSipple