Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setAttributeNS -> setAttribute, add modal utils tests #312

Merged
merged 3 commits into from
Jan 13, 2019
Merged

setAttributeNS -> setAttribute, add modal utils tests #312

merged 3 commits into from
Jan 13, 2019

Conversation

RobbieTheWagner
Copy link
Member

No description provided.

BrianSipple
BrianSipple reviewed Jan 13, 2019
View reviewed changes
src/js/utils/modal.js Outdated Show resolved Hide resolved
BrianSipple
BrianSipple reviewed Jan 13, 2019
View reviewed changes
Copy link
Contributor

@BrianSipple BrianSipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments/suggestions, but overall looks great! 👍

@RobbieTheWagner RobbieTheWagner merged commit 888a218 into master Jan 13, 2019
@RobbieTheWagner RobbieTheWagner deleted the modal-tweaks branch February 18, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianSipple BrianSipple BrianSipple left review comments

@chuckcarpenter chuckcarpenter Awaiting requested review from chuckcarpenter

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobbieTheWagner @BrianSipple