[WIP] Popper v2 #752
[WIP] Popper v2 #752
Conversation
|
The eslint problem is a bug with the plugin: TrySound/rollup-plugin-eslint#40 Downgrade to 6.0.0 and it will work apparently |
|
@atomiks downgrading throws other errors. We can keep it commented out for now. |
chuckcarpenter
force-pushed
the
popper-v2
branch
from
343675a
to
0ac0063
Compare
chuckcarpenter
force-pushed
the
popper-v2
branch
from
d3cca41
to
5752bd0
Compare
| expect(tetherOptions.classes.element).toBe('bar'); | ||
| }); | ||
|
|
||
| it('constraints can be overridden', function() { |
There was a problem hiding this comment.
Should we replace these tests with some popperOptions tests? Would be good to make sure deeply nested options can be passed and override ours. I had issues with this in the past.
There was a problem hiding this comment.
I was a little back and forth on this, but should it be on the implementor to understand what they're passing in and use v2 docs?
There was a problem hiding this comment.
We should add tests for the options merging is what I mean. like options.modifiers.foo.bar and make sure that overrides our defaults and can still be passed down, and we don't clobber it. Does that make sense?
There was a problem hiding this comment.
I had a lot of issues before with using Object.assign and accidentally clobbering nested options.
docs-src/tutorials/02-usage.md
Outdated
| [`appendTo` option](https://atomiks.github.io/tippyjs/#append-to-option) by defining it on the | ||
| `tippyOptions` hash inside of each Step's options hash. | ||
| By default, tour steps will append their elements to the `body` element of the DOM. This is perfect for most use cases, but not always. If you need to have steps appended elsewhere you can take advantage of Popper's | ||
| [options](https://popper.js.org/docs/v2/constructors/#options) by defining it on the |
There was a problem hiding this comment.
What popper option would be used for this? We may want to be explicit here.
There was a problem hiding this comment.
Actually, this is a tippy option and we easily do this with Step.target. Going to remove.
There was a problem hiding this comment.
I don't think step.target is the same thing. This is defining the container the step element itself lives in right?
There was a problem hiding this comment.
if you look at the docs on createPopper() The first arg is target and we map target there. Maybe I'm not clear on what you mean then?
There was a problem hiding this comment.
Target is what you are attaching the popper to. appendTo is where the tooltip element itself lives.
|
@chuckcarpenter I think the only thing missing from this PR is constraining to window. i.e. when the window shrinks and there is no room to flip to the other side, the tooltips should start moving to the middle of the target, to allow them to be read. |
chuckcarpenter
force-pushed
the
popper-v2
branch
from
8c7692c
to
82b2939
Compare
Giving Popper v2 a try, in the hopes that it is smaller and performs better than Tether.