Only move tethered element if its offset parent is not the body #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamschwartz
changed the title
| if(!moved && this.element.parentNode.tagName !== 'BODY') { | ||
| let offsetParentIsBody = true; | ||
| let currentNode = this.element.parentNode; | ||
| while (currentNode && currentNode.tagName !== 'BODY') { |
There was a problem hiding this comment.
You can move the if (!moved) check above this code to prevent it from having to be executed if it's already clear we're not gonna move the element again.
|
Nice job! I made a couple minor comments, but otherwise LGTM. |
…nt is not the body
pzuraq
force-pushed
the
only-move-when-not-static
branch
from
96180ea to
ffb3118
Compare
|
Thanks! Addressed those comments, everything should be in order now! |
zackbloom
added a commit
that referenced
this pull request
Jul 15, 2015
Only move tethered element if its offset parent is not the body
|
Thanks @pzuraq |
This was referenced May 11, 2016
This was referenced Aug 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to discussion in #96.
@zackbloom