Add the angle grinder, a tool to deconstruct structures quickly #1716
Conversation
github-actions
bot
added
Code change
|
Could make this work on the broken machines found on wasteworlds as a quicker alternative to the crowbar you have to use on them. |
|
Will you be adding it into Industrial Engineering or Advanced Tools as an engineering/supply protolathe item? |
…roc and the signal that goes with it
|
Needs availability in the Engineering and Supply lathes for sure. You should also allow it to cut down airlocks (either destroy the boards/wires or require the user to switch to crowbar/cutters for those), that’s kind of a critical requirement for a salvage/deconstruction tool |
Doesn’t really make sense, a grinder would reasonably just destroy whatever valuable components are actually inside the derelict machines. |
|
spacr emgineers |
i would quite argue that, they could just grind around the components that they want. |
it’s an industrial angle grinder, not a dremel tool. this thing takes two hands to use and saws through girders, it really doesn’t seem like something capable of precision work in the slightest. |
|
That doesn't stop John Space Engineers though, and in a few ways spessmens are capable of even more than them |
|
I think we could argue both way for the logic of salvaging circuits, I think we should think in term of balance |
|
I already coded the feature but we could still revert it later |
well, my take from a balance and design perspective is that while having a tool that massively simplifies and expedites salvaging is good, it isn’t necessarily engaging to have a single tool capable of doing everything on its own. Part of the original conversation that led to the creation of the grinder was that salvage is too slow and unrewarding compared to mining, as far as raw resources like metal sheets go. That’s true, and the reason is specifically because dismantling walls and airlocks and the like takes a long time and only yields a few sheets of metal each. And airlocks aren’t even remotely worth it because you have to hack them first. Machines, meanwhile, are more of a source of boards and components than they are of raw materials, and they’re higher value for time spent anyway. Plus the broken rockplanet ones are just a single-step dismantle with a crowbar anyway, it’s not a long process. |
IMO it shouldn't be aviable from a lathe at all. Only salvage ships should start with / it should be available at the outpost. Being able to deconstruct pretty much anything is a very powerful ability and requiring only research to get it would let the not specialized ships do salvage just as easily as mining nullifying one of the points of the original conversation |
|
I don't really like JackOfAllTrade tools; and as such do not really like this |
|
Looking forward to the Gecko remap after this. Specialization and earmuffs, let's go. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
| #define ANGLEGRINDER_OUTPOST_PRICE 1000 | ||
| // #define ANGLEGRINDER_BROKEN_MACHINE_SALVAGE_TIME 2.5 SECONDS | ||
| #define ANGLEGRINDER_OPEN_SAFE_TIME 90 SECONDS | ||
| #define ANGLEGRINDER_OPEN_CLOSET_TIME 5 SECONDS | ||
| #define ANGLEGRINDER_RAILING_TIME 1 SECONDS | ||
| #define ANGLEGRINDER_MACHINE_FRAME_TIME 3 SECONDS |
There was a problem hiding this comment.
These should be config entries not defines.
There was a problem hiding this comment.
Honestly I don't know how to do all of this cleanly using config without making some wacky code or hurting performance. I could have also hard coded all the value as it's usually done, but it would make balancing and tweaking of the feature harder.
|
does this still need inhands |
|
I didn't see it get used that much while it was test merged but it shouldn't break tremendously if it end up a having an issue. |
|
|
||
| /obj/item/anglegrinder | ||
| name = "angle grinder" | ||
| desc = "A powerfull tool to salvage about anything. You better wear some protection tough" |
There was a problem hiding this comment.
minor spelling/grammar mistakes. "A powerful tool to salvage just about anything, you better wear some protection though."
Preferably, I would replace that second part with something that outright states what is protection. "...anything, you should wear earmuffs and welding protection to avoid damage to your ears and eyes." would be my best guess but something longer might be better.
| @@ -1,4 +1,4 @@ | |||
| //Originally coded by ISaidNo, later modified by Kelenius. Ported from Baystation12. | |||
| //riginally coded by ISaidNo, later modified by Kelenius. Ported from Baystation12. | |||
There was a problem hiding this comment.
I dont know what the O in Originally did to deserve being deleted but you should probably fix it.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Resolve the merge conflict please. |
|
This PR has been inactive for a month. This means it is at risk of being auto closed in a week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
…ead of mining (and base gearpacks) (#3146) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request re-implements #1716 as a base and adds cutter functionality to plasma cutters also implements and uses gear packs from #2103 that never got in. makes plasma cutters unable to mine, shorter range, and do burn instead of brute. angle grinders are integrated into grinder packs, like water backtanks. Also draws power from a cell. jackhammers can no longer break down walls and girders. ### Cutters can currently deconstruct: - girders - walls - reinforced walls - airlocks - airlock frames - grilles - machine frames - computer frames - catwalks - chairs - beds - tables - lockers & crates - salvage machines (the wasteplanet ones) - railings - lattice - wooden barricades cutters can also cut open safes and locked lockers & crates attempted to revert map changes but using git checkout doesn't completely revert the gecko. Will try again later. adds a mech salvage saw and a prototype energy saw. Doesn't make either available yet. sprites by me  https://github.com/shiptest-ss13/Shiptest/assets/90987989/12262338-055f-4c7c-86d1-d31279ab953c <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Jackhammers as a main salvage tool is dumb, and angle grinders and cutters make more sense and have better functionality. Cutting apart old ruins and ships should be a reasonable source of material and shouldn't take years. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: angle grinders for salvage add: reworks plasma cutters for salvage /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: HelmCrab <90987989+Thera-Pissed@users.noreply.github.com> Co-authored-by: ritorizo <ritorizo@localhost> Co-authored-by: FalloutFalcon <falloutfalconplays@gmail.com> Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
…ead of mining (and base gearpacks) (shiptest-ss13#3146) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request re-implements shiptest-ss13#1716 as a base and adds cutter functionality to plasma cutters also implements and uses gear packs from shiptest-ss13#2103 that never got in. makes plasma cutters unable to mine, shorter range, and do burn instead of brute. angle grinders are integrated into grinder packs, like water backtanks. Also draws power from a cell. jackhammers can no longer break down walls and girders. ### Cutters can currently deconstruct: - girders - walls - reinforced walls - airlocks - airlock frames - grilles - machine frames - computer frames - catwalks - chairs - beds - tables - lockers & crates - salvage machines (the wasteplanet ones) - railings - lattice - wooden barricades cutters can also cut open safes and locked lockers & crates attempted to revert map changes but using git checkout doesn't completely revert the gecko. Will try again later. adds a mech salvage saw and a prototype energy saw. Doesn't make either available yet. sprites by me  https://github.com/shiptest-ss13/Shiptest/assets/90987989/12262338-055f-4c7c-86d1-d31279ab953c <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Jackhammers as a main salvage tool is dumb, and angle grinders and cutters make more sense and have better functionality. Cutting apart old ruins and ships should be a reasonable source of material and shouldn't take years. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: angle grinders for salvage add: reworks plasma cutters for salvage /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: HelmCrab <90987989+Thera-Pissed@users.noreply.github.com> Co-authored-by: ritorizo <ritorizo@localhost> Co-authored-by: FalloutFalcon <falloutfalconplays@gmail.com> Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
About The Pull Request
The angle grinder is a powertool which is used to deconstruct things quickly, it's intended for salvaging structures.
It curently works on :
It require eye protection to be used like welding tools.
It also works as a getho bone saw (at 80%)
It's currently only obtainable in the outpost.
Sprite (thanks
NIRV-0025NIRV-0026)Why It's Good For The Game
The idea was to add another way of getting resources than mining ores (maybe to make ore processing harder at some point) and just be a building tool.
More feature will be added eventually but it could be cool to test it early for feedback (like what stuff to add, buff, debuff...)
Changelog
🆑
added: The angle grinder, a quick deconstruction tool.
added: A sprite for the angle grinder (made by NIRV-0024)
/:cl: