Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destructible Walls #3145

Draft
wants to merge 51 commits into
base: master
Choose a base branch
from
Draft

Conversation

Gristlebee
Copy link
Contributor

@Gristlebee Gristlebee commented Jun 23, 2024

About The Pull Request

Moves the damage behavior from concrete walls to base walls.
Plasma cutters are now more of an engineering tool, and acts as an "upgrade" to the welder and deconstructs walls faster, and can repair prosthetic limbs. They can still mine, but lose the additional mining range and has a chance to ruin ores. They now fit in toolbelts.
Basic walls can be repaired with a welder.
Basic walls are still deconstructed with a welder, but it now starts a repeatable do after that reduces the wall's integrity more efficiently than simply attacking.
R-walls integrity is tied to their deconstruction state. Damaging one enough will move it down a state, and can be repaired by following the construction steps. They can still be deconstructed the same as before, or with a plasmacutter.
Cleans up crate/closet deconstruction. It now checks for tool_behavior rather than a specific tool and non-help intent.

Moves plasmacutters and advanced plasmacutters from mining to tech plasma manipulation and adv plasma manipulation tech respectively.

Adds plasmacutters to the Mudskipper, Riggs, Talos, Gecko, Heron, Osprey, Ranger, Hyena, Komodo, Shetland and Twinkleshine

Adds plasmacutters to cargo for 1250 credits

Why It's Good For The Game

Rylie asked me to make this.

Currently, it's much easier to go through a wall than a door if you want to force entry as it's as simple as having a welder or a jackhammer to take off the wall plating vs having to take the time hack an airlock, which probably isnt great. Also gives some counterplay if you're on the defending side since you have the opportunity to repair compromised walls or go around and attack the breacher.

This would add more possible interactions and play around with walls since you no longer need these two specific tools to get through a wall. If you say, have enough ammo you could theoretically just shoot your way in, and they're no longer indestructible pieces of cover.

Changelog

🆑
add: Welders/Plasmacutters now deal damage to wall integrity to decon
add: Plasmacutters are now engineering tools and fit in toolbelts. They can damage ores into slag if used to mine. They are now researched with plasma technology and advanced plasma technology.
add: Plasmacutters to cargo for 1250
add: Adds plasmacutters to the Mudskipper, Riggs, Talos, Gecko, Heron, Osprey, Ranger, Hyena, Komodo, Shetland and Twinkleshine
del: Plasmacutters extra mining range
fix: Plasmacutters can repair prosthetic limbs like welders
code: Moves damage behavior of concrete walls to normal walls. Basic walls are now repaired with a welder.
code: R-walls d-state tied to their integrity. R-walls can be deconstructed with plasmacutters.
code: Crate decon checks for tool behavior rather than a istype check

/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Jun 23, 2024
@Gristlebee Gristlebee marked this pull request as ready for review June 26, 2024 06:37
@Gristlebee Gristlebee requested a review from a team as a code owner June 26, 2024 06:37
@thgvr thgvr marked this pull request as draft July 3, 2024 23:19
Copy link
Member

@thgvr thgvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some form of visual and audio feedback on damaged walls

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jul 8, 2024
@@ -74,6 +74,12 @@
contains = list(/obj/item/pickaxe/drill/jackhammer)
crate_name = "jackhammer crate"

/datum/supply_pack/tools/jackhammer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overwrites the other jackhammer crate, probably meant to be tools/plasmacutter or similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeeeep. That it is. Thanks for catching that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Test Merged They've done it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants