[MDB Ignore] Rkz's Newfood: Part 1 of 4

[Tsar-Salat]

About The Pull Request

This is a port of my beestation newfood pr. It's the culmination of many months of effort during my free time in university, and my first large-scale project on bee.

Due to interest from a few shiptest people, I have ported the PR mostly-as-is from Bee, additional alterations where needed.

Ports from TG:

• Adds the dunkable element tgstation/tgstation#49192
• Food refactor part 1: Bread destruction and processable element tgstation/tgstation#53047
• Adds a food trash element tgstation/tgstation#53225
• Moves over cakes to newfood and transfers reagents when crafting tgstation/tgstation#53316
• s-s-s-spaghetti to newfood tgstation/tgstation#53574
• Fixes consistency issue with processing foods without a table tgstation/tgstation#66257
• fixes error food spawning tgstation/tgstation#69095
• Gives bread and cake slice_types and adds screentip verbs to proccessed foods tgstation/tgstation#71449

Ports from Bee, from yours truly:

• Newfood: Part 1 of 4 BeeStation/BeeStation-Hornet#8748

A rundown of the plan:

• This is Part 1 of newfood. This is basically the foundational newfood shit that's needed for the rest of the system we want to work.

• Part 2 will complete all the foundational shit (killing oldfood), with some minor refactors to ready cooking for the upcoming features. This will conclude the development of the edible component and things left in limbo from part 1. It will remove the temporary vars and procs, and customizable food will be fully reenabled.

• Part 3 will contain the cooking features (Griddle).

Now for the changes:

1. convert bread to newfood
2. convert spaghetti to newfood
3. convert cake to newfood
4. Cleaned up the edible component. It should be a lot more consistent going forward, and will basically be completely functional as of part 2's merge.
5. Adds Food Storage component, which lets you hide small items in large food. (Stick a shard of glass inside a cake to fuck over someone.)
6. Adds FOOD_FINGER_FOOD food flag, which lets you eat food whilst moving. It applies to small food that really shouldnt take your full concentration to consume whilst walking, like lollipops!
7. Sets PRAGMATIC weights for as many foods as I could. Seriously this sucked really bad. candycorn and cakes are not the same ducking size.
8. food trash is sane, stuff thats clearly eaten on a plate and has a plate underneath it, will spawn a plate rubbish when completely eaten. (you dont eat the plate on cake any more smh)
9. Begins the framework of something called Accidental Consumption. Its basically if you end up eating non-food related it will cause you differing effects. This is again very early stages, and will require wounds, full newfood implementation, and bringing over tg's stomach metabolism. The proc exists, but its not getting called until part 2 or 3 is merged.
10. Adjusts some nutritional values. Minor, but I will note that I did so

Why It's Good For The Game

Newfood seems to be a heavily requested feature here. This is but the framework. Really, players wont notice the difference besides the incompatiblity between oldfood & newfood, but once the griddle is implemented in part 3, it will be glorious.

When discussing with shiptest, I floated my plan and I received overall agreement. This should hopefully be less painful for me and for you than a bulk merge.

Changelog

🆑 rkz, benbot(benjamin), Time-Green, SteelSlayer, floyd, Qustinuus, ArcaneDefence, FlowerCuco
add: Food storage! Hide some glass in the captains cake! Begone digestive tract!
add: Bread, Cake and Spaghetti to Newfood
add: some smaller foods can now be eaten whilst on the run! (This ONLY applies to newfood items thus far!)
add: converted edible component to work with newfood
del: oldfood for Bread, Cake and Spaghetti
del: Temporarily removes customfood bread, cake, pasta, and sandwiches
tweak: edited a few messed up values
tweak: food trash is sensible now. Finishing stuff like cake will actually spawn a plate rubbish. Instead of you eating the plate, biggun, perhaps properly dispose of it!
fix: Wildly STUPID item weights. Candycorn and cakes are no longer the SAME size
code: provides some semblance of sorting for signal defines
/:cl:

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[thgvr]

Might have to run updatepaths again for that map error