Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crying Sun Job Updates / PGF Clothing Cold Protections #3190

Closed
wants to merge 12 commits into from

Conversation

Skrem7
Copy link
Contributor

@Skrem7 Skrem7 commented Jul 8, 2024

About The Pull Request

A FULL review of what this PR does:

  • Updates the bridge of the Crying Suns to incorporate the Bridge Crew's transition to Helmsman. Meant to be a bridge-local spot, focusing on intel, information gathering, and relaying information with the Captain to better allow them to work with the Marines for an efficient operation. Rather, they stay on the bridge. Period. They're not a head
  • Fixes the turrets on the Crying Sun to respond to the lever. The Nail's turret should be set to lethal by default
  • Adds a security camera console to the bridge to allow for full bridge monitoring
  • Adds doctor access to the checkpoint to permit the doctor to access their monitoring console
  • The Sergeant now has their own standard vest, if they don't desire the coated variant. In addition, they're considered an officer and have had their name updated to Marine Lieutenant
  • Silkenweave jackets and Betiz hats now offer zero armor, but cold protection, for people moving onto frosty planets
  • Gear has been adjusted within the Crying Suns to respect the fact that the armory is for marines, and marines only
  • The radiation crate in stowage now contains radiation suits for the Navy Engineers
  • The engines on the Crying Sun are now primarily combustion-based. Hope you know your atmospherics
  • A note is now included within the grounding rod crate to better inform engineers of potential tomfoolery
  • Illegal alcohol added to captain's quarters for potential yaoi/yuri
  • Sarathi should be able to consume any Gezenan-concocted drink, now

The new bridge:
StrongDMM_s4pYcfc504

The curious drinks:
StrongDMM_nwknNTfjYA

Why It's Good For The Game

Modernizing and keeping our ships up to state is important. Making the role not a baseline crewmate helps to appeal to players who want to get into the faction whilst still permitting crewmates to shadow ANYONE

As for the silk/betiz changes, it's good to allow crew to deploy without needing to equip a softsuit, as Gezenan winter coats don't exist, nor would they fit well, in my opinion. Offering trade-offs for variants that make sense in-lore is always nice

Changelog

🆑
code: Bridge Crew on the Crying Sun is now an Helmsman, with their own locker. Not a head
code: Marine Sergeant is now an officer with name changed to Marine Lieutenant
code: Several item placement adjustments on the Crying Sun have been made to better intend design
balance: Silkenweave jackets and Betzu hats now provide cold protection but no armor
fix: Bottles that advertise themselves as mead should be consumable by sarathi now
balance: Crying Sun now has 4 combustion/2 ion engines instead of 2/4
fix: Fixes the turrets on the Crying Sun and the Nail
/:cl:

@Skrem7 Skrem7 requested a review from a team as a code owner July 8, 2024 01:39
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Jul 8, 2024
@Skrem7 Skrem7 changed the title Crying Sun Intelligence Officer + Updates / PGF Clothing Cold Protections Crying Sun Bridge Officer + Updates / PGF Clothing Cold Protections Jul 8, 2024
@Apogee-dev
Copy link
Contributor

If the Bridge Officer isn’t actually an officer, I’d choose a job title that doesn’t imply as much. Why not something more explicit about their primary role, like Helmsman or Navigator or somesuch?

@Skrem7 Skrem7 changed the title Crying Sun Bridge Officer + Updates / PGF Clothing Cold Protections Crying Sun Bridge Steward + Updates / PGF Clothing Cold Protections Jul 11, 2024
_maps/configs/pgf_crying_sun.json Outdated Show resolved Hide resolved
_maps/configs/pgf_crying_sun.json Outdated Show resolved Hide resolved
@Skrem7 Skrem7 changed the title Crying Sun Bridge Steward + Updates / PGF Clothing Cold Protections Crying Sun Job Updates / PGF Clothing Cold Protections Jul 11, 2024
Copy link
Member

@Latentish Latentish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
This doesn't not work. The cups are literally hanging off the table, the bottle is scrunched in with the plushie. If you're going to add glasses and a bottle here, redo the table to make it look nice. You can edit the layer var on some of the objects like the window/girder/shutter so you can move the lamp up in front of it. But overall you're going to need to redo this table or remove the glasses and bottle.

image
This also needs some work. If you're going to pixelshift a locker's contents, you can't have them underlap the light on that tile. You should move the light to the middle wall, and redo this locker. Remember not to have your items overlap a wall, and moke sure the locker actually has some good room to be clicked on. I suggest spreaeding things out and paying attention to the layering of objects, as the goal is to make it so as many of those items can be clicked o n without a context menu as possible, without looking like a mess. Something I would avoid is space between items like you have with the jacket and the duffelbag. Though I have to be honest I don't want the helmsmen having half these items. They should really just being wearing standard navy gear, which they can get in the crew area. I don't really see why they need a locker.

Also please add an image of the bridgte without the windows, grills, or shutters, as I'd like to make sure that wiring and firelocks are good.

"Marine Sergeant": {
"outfit": "/datum/outfit/job/gezena/hos",
"Helmsman": {
"outfit": "/datum/outfit/job/gezena/hop",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this back to assistant/bridge or change that to another version. I'd also like to see what all you put in their locker, because I don't really think they need one.


/obj/item/paper/fluff/shuttles/cryingsun
name = "Electro-proofing Your Crying Sun"
default_raw_text = "Quartermaster said we have to drag these grounding rods and tesla coils on for you, and you might be wondering how you can use them. Supposedly, if you're not needing external defenses or asteroid turrets, you can replace each of the external turrets with a tesla coil and generate some power running through any storms. The two empty platings in the back fit grounding rods - fit all the spots and you should be fully covered."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't entirely accurate. Most of the turrets fit tesla grounds. Look at the wire placement to see which ones. This implies only the two at the back do.

@@ -260,20 +265,20 @@
item_state = "blackcloth"

/obj/item/clothing/neck/cloak/gezena/lead
name = "sergeant's Azuilhauz"
desc = "The “Aziulhauz”, or “rank-cape”, is the method with which PGF military members display their rank to others. Wearing one while on duty is required by uniform code. This variant displays the wearer's rank as a squad commander."
name = "squad leader's Azuilhauz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to Marine Officer's Azuilhauz as they're a Lieutenant

name = "sergeant's Azuilhauz"
desc = "The “Aziulhauz”, or “rank-cape”, is the method with which PGF military members display their rank to others. Wearing one while on duty is required by uniform code. This variant displays the wearer's rank as a squad commander."
name = "squad leader's Azuilhauz"
desc = "The “Aziulhauz”, or “rank-cape”, is the method with which PGF military members display their rank to others. Wearing one while on duty is required by uniform code. This variant displays the wearer's rank as a marine squad leader."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, change to "rank as a marine officer"

@Skrem7
Copy link
Contributor Author

Skrem7 commented Jul 14, 2024

too tired to try and keep fighting for even the smallest give toward what I think would be better for this faction

@Skrem7 Skrem7 closed this Jul 14, 2024
@Skrem7 Skrem7 deleted the crying-sun-officer branch July 14, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants