Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoodie/Winter Coat Storage Parity #3191

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Skies-Of-Blue
Copy link
Contributor

About The Pull Request

Winter coats lost their innate storage due to an oversight in #2121. This fixes that!

Additionally, this PR matches the items you can fit in the suit storage slot across hoodies and coats. As an added bonus, you can now fit pill bottles in both!

Why It's Good For The Game

Things working as intended is good, and one should reasonably be able to fit a pill bottle in your coat pocket.

Changelog

🆑
balance: you can now fit radios and pill bottles in both hoodies and winter coats
fix: the innate storage on winter coats has been restored, alt click to access!
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Jul 8, 2024
@thgvr
Copy link
Member

thgvr commented Jul 8, 2024

Might not be the best idea, i meant to take it off of hoodies...

The hood for the coat is put into the object's storage, which makes it show up in its 'pockets' and I dunno a good way to fix it

@Imaginos16
Copy link
Member

I think it'll be fine, personally. Not sure why one should behave one way while the other doesn't.

@Imaginos16 Imaginos16 added this pull request to the merge queue Jul 12, 2024
Merged via the queue into shiptest-ss13:master with commit b36878e Jul 12, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jul 13, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Winter coats lost their innate storage due to an oversight in
shiptest-ss13#2121. This fixes that!

Additionally, this PR matches the items you can fit in the suit storage
slot across hoodies and coats. As an added bonus, you can now fit pill
bottles in both!
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Things working as intended is good, and one should reasonably be able to
fit a pill bottle in your coat pocket.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
balance: you can now fit radios and pill bottles in both hoodies and
winter coats
fix: the innate storage on winter coats has been restored, alt click to
access!
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants