Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlas-class Light Armored Crusier #3246

Merged
merged 45 commits into from
Oct 17, 2024

Conversation

meemofcourse
Copy link
Contributor

@meemofcourse meemofcourse commented Jul 25, 2024

About The Pull Request

imagen
atlas2

The Atlas-class is the first Colonial League ship following the CLIP Rework. The decaling and general decoration of the ship needs a revision, but otherwise, it is intended as a small, overall generalist patrol vessel to the likes of the Vaquero. The 4-Minutemen team, lead by one Sergeant, is subordinate to the First Officer and Captain, who overlook the operation of the ship by the Corpsman and the Engineer.

It is staffed by:

  • 1 Captain
  • 1 First Officer
  • 1 Sergeant
  • 1 Corpsman
  • 1 Engineer
  • 4 Minutemen
  • 1 Deckhand

Why It's Good For The Game

it's the clip ship it uses the colon league content

Changelog

🆑
add: Atlas-class Light Armored Crusier
/:cl:

@meemofcourse meemofcourse requested a review from a team as a code owner July 25, 2024 02:23
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Jul 25, 2024
@kaylexis
Copy link

CLIP IS SO BACK.

@Martinpachu
Copy link
Contributor

it's peak chat

@Martinpachu
Copy link
Contributor

imagen
it has a 762 box but no guns that use 762 i think?

@Martinpachu
Copy link
Contributor

there's no gravity generator!!

@Martinpachu
Copy link
Contributor

i might be a stupid baby but i don't think the cargo bay doors are linked to any buttons. also no holofields ? also just my dumb gay opinion but there could be another candor mag

@firebudgy
Copy link
Contributor

firebudgy commented Jul 25, 2024

image
I think you forgot a couple wires for the engines here

@firebudgy
Copy link
Contributor

image
Bridge lockdown button closes all these shutters, while the bridge windows button does nothing

image
Every other ship usually has windows blocking the dorms so SSD people don't get obliterated by carps while away from their computer, so I'm just wanting point it out in case you forgot or something

image
Same with the medical bay external window shutters, I'm just pointing this out in case their omission was an accident

@Sadhorizon
Copy link
Contributor

Sadhorizon commented Jul 25, 2024

  • They don't have a single space suit on the entire ship.
    obraz
  • Why is it just... sticking out like that... surely there is a better way to handle it. Maybe a window into grilles?
    obraz
  • Most ships have shutters on the precharger. Cuz, technically, you are blocking engine output rn. (lore-wise)
  • The cargo bay has very little cargo space. I'd suggest, on the right side, making more room for a crate shelf. Also switching the air tank rack for an air tank crate, cuz it's less stationary.
    obraz
  • This locker has the wrong dir.
    obraz
  • This airlock has no controller and no vents.
    obraz
  • Empty space spotted. Could put a vendor or something here. Cigs never hurt anybody.
    obraz
  • No air pump? Also, missing cable (marked green).
    obraz
  • You forgot holofields, and also a shutter button.
  • Bridge airlocks don't have access req set.
  • Airlocks aren't named. Probably not needed, but still nice to have.
    obraz
  • You have two air cans, but no ports to put them in. Would probably be nice.
  • All of your light switches are like. Very high. Latency explained to me before, that shadow should be touching the ground. Just pointing it out.
    obraz
  • When those are next to each other, .i makes you speak on both, which is kinda annoying.
  • Medical lacks surgical tools.
  • There is no CLIP stamp on board.

@Martinpachu
Copy link
Contributor

small suggestion, maybe start with a bit of glass and iron for the autolathe?

@Martinpachu
Copy link
Contributor

imagen
the turret panel is unreachable

@Sadhorizon
Copy link
Contributor

small suggestion, maybe start with a bit of glass and iron for the autolathe?

Some plastic is neat to have too! Just a lil bit, for when you need it.

@Martinpachu
Copy link
Contributor

deleted because im stupig nevm

@meemofcourse
Copy link
Contributor Author

imagen it has a 762 box but no guns that use 762 i think?

imagen
:(

@meemofcourse
Copy link
Contributor Author

Why is it just... sticking out like that... surely there is a better way to handle it. Maybe a window into grilles?

nah

Empty space spotted. Could put a vendor or something here. Cigs never hurt anybody.

i am avoiding vendors on the argument that this is a military vessel

There is no CLIP stamp on board.

intended for admin use. you shouldn't be able to stamp things on behalf of the entire country

@Martinpachu
Copy link
Contributor

imagen
cargo bay doors opens only one door. also, idk if i just didn't see it, but there should be a cell charger somewhere. since that's standard for every ship i believe.

@Martinpachu
Copy link
Contributor

actually, weren't communications consoles off limits? since you can do stuff like request nuclear access codes and send announecements. i vaguely remember them not being allowed.

Copy link
Contributor

@Gristlebee Gristlebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reduce the amount of extra mags for the CM-82, and CM-5 to two since there's only one of each now. It would also be good to swap out the combat knives for survival knifes to bring it in line with other ships.
image

Aside from that, everything looks pretty good to me.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 9, 2024
Signed-off-by: meem <75212565+meemofcourse@users.noreply.github.com>
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 9, 2024
@Erikafox
Copy link
Contributor

recently played on this. here are my thoughts

image
you should curve the railings, the middle tile that's obviously technology feels weird to stand on.
image
Honestly thought this was kinda ugly
image
don't care for the engines in this style. I think being able to see the terminals is kinda assumed. Maybe put some decalling where they should be? The steeldecal plates are good for that.
First Officer and Captain should have a spare CMM bag (and imo should spawn with one, the captain bag doesn't fit them too well)
image
This feels somewhat haphazard
Airlocks all need to be labelled
image
this is like. a lot of unused space imo. take some of it and give the captain a nice little front office?
image
spread some folders out on the tables - and put some paperwork stuff in the bridge too.
image
this does not look good in game
image
You may want to secure the blackbox somewhat
image
These should be SSU'd. maybe take some cargo bay space (and expand it a bit) to accomodate, or eat into the briefing area.
image
grav gen feels kinda just. tacked on there.

@meemofcourse
Copy link
Contributor Author

thats it bitch im coming for you

@meemofcourse
Copy link
Contributor Author

don't care for the engines in this style

What

take some of it and give the captain a nice little front office?

no

put some paperwork stuff in the bridge too.

there is a paper cutter, paper bin, photocopier, clipboard, and stamps i literally dont know what more you want. i'm not adding the clip stamp because standard individual ships should not be able to give the approval of an entire nation

@Erikafox
Copy link
Contributor

engines

I just prefer the style of seeing the terminal and having more like.. technical grunge around it

Rest is fair its your ship

@Sadhorizon
Copy link
Contributor

please fix this
obraz

@goober3
Copy link
Member

goober3 commented Oct 15, 2024

a8d2c65a1b1debfea67dcc6eb6715715
just a thought- consider turning this external injector into more of a feature somehow. maybe some decals or railings, think about expanding the platform its on. it feels somewhat haphazard in its placement at the moment. also please fill that corner next to the engine precharger or move the water tank towards it.

@Gristlebee
Copy link
Contributor

This PR should be good to go.

@Latentish Latentish added this pull request to the merge queue Oct 17, 2024
Merged via the queue into shiptest-ss13:master with commit e20f2d8 Oct 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.