Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify CI job doesn't check CRD generation #943

Closed
adambkaplan opened this issue Nov 12, 2021 · 1 comment · Fixed by #946
Closed

Verify CI job doesn't check CRD generation #943

adambkaplan opened this issue Nov 12, 2021 · 1 comment · Fixed by #946
Assignees
@shahulsonhal
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
release-v0.7.0

Comments

@adambkaplan
Copy link
Member

We have a Verify CI job that runs basic static analysis, like code linting. This step should also ensure that CRD definitions for the Build APIs are aligned with what is in the golang code.

Originally posted by @SaschaSchwarze0 in #941 (review)
@SaschaSchwarze0
Copy link
Member

@shahulsonhal had mentioned this in our standup also and sounded like he wanted to contribute the fix for this.

@adambkaplan adambkaplan added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 17, 2021
@adambkaplan adambkaplan added this to the release-v0.7.0 milestone Nov 17, 2021
shahulsonhal pushed a commit to shahulsonhal/build that referenced this issue Nov 22, 2021
Update Verify CI job to check CRD generation
9cb1aa3 
We have a Verify CI job that runs the basic static analysis, like code linting. This step should also ensure that CRD definitions for the Build APIs are aligned with what is in the golang code.
Fixes shipwright-io#943

Update hack/verify-generate.sh to check CRD generation
Update deep copy generation file not in sync
shahulsonhal pushed a commit to shahulsonhal/build that referenced this issue Nov 22, 2021
Update Verify CI job to check CRD generation
a998897 
We have a Verify CI job that runs the basic static analysis, like code linting. This step should also ensure that CRD definitions for the Build APIs are aligned with what is in the golang code.
Fixes shipwright-io#943

Add hack/verify-controller-gen.sh to check CRD generation
Update hack/verify-generate.sh to check for deep copy generation
Update deep copy generation file not in sync
shahulsonhal pushed a commit to shahulsonhal/build that referenced this issue Nov 22, 2021
Update Verify CI job to check CRD generation
7f159f7 
We have a Verify CI job that runs the basic static analysis, like code linting. This step should also ensure that CRD definitions for the Build APIs are aligned with what is in the golang code.
Fixes shipwright-io#943

Add hack/verify-controller-gen.sh to check CRD generation
Update hack/verify-generate.sh to check for deep copy generation
Update deep copy generation file not in sync
@shahulsonhal shahulsonhal mentioned this issue Nov 22, 2021
Merged
4 tasks
shahulsonhal pushed a commit to shahulsonhal/build that referenced this issue Nov 23, 2021
Update Verify CI job to check CRD generation
b6ea016 
We have a Verify CI job that runs the basic static analysis, like code linting. This step should also ensure that CRD definitions for the Build APIs are aligned with what is in the golang code.
Fixes shipwright-io#943

Update hack/verify-generate.sh to check CRDs and deep copy generation
Update deep copy generation file not in sync
sm43 pushed a commit to sm43/shp-build that referenced this issue Nov 24, 2021
Update Verify CI job to check CRD generation
2b02afb 
We have a Verify CI job that runs the basic static analysis, like code linting. This step should also ensure that CRD definitions for the Build APIs are aligned with what is in the golang code.
Fixes shipwright-io#943

Update hack/verify-generate.sh to check CRDs and deep copy generation
Update deep copy generation file not in sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahulsonhal shahulsonhal

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
release-v0.7.0
Development

Successfully merging a pull request may close this issue.

Update Verify CI job to check CRD generation shahulsonhal/build
3 participants
@adambkaplan @shahulsonhal @SaschaSchwarze0