Re-run make generate and generate-crds #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/cleanup
qu1queee
requested changes
May 26, 2021
|
@imjasonh btw, I think CI is not calling our |
Yes - our go code needs to be the source of truth. Any PR that changes our API godoc needs to ensure that the generated CRDs include those changes, otherwise we'll never update our API on the cluster. |
qu1queee
approved these changes
Jun 9, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Good catch! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It seems like the repo has gotten out of sync with generated code, which led to some unnecessary diffs in some changes I was working on. Mostly just copyright headers and diffs from controller-gen
v0.4.1->v0.5.0.Should we have a CI check that tries to check that codegen is up-to-date?
Also git-ignore binaries generated by
go build ./cmd/..../kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes