Alter subprocess's environment instead of the hosts #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schmichael There are a number of additional uses of LC_ALL in the other common_* platform files. Also, since this was setting that for the entire process space, the usage of exec.Command in process_darwin.go and common.go might also need to be replaced depending on if any of the invocations that touch those end up depending on locale specific formatting/encoding. Isn't text processing FUN?! |
|
@nugend Ha, indeed. Fixed them all and added a little test for the env munging. |
|
@schmichael Thanks. I think I just need to bite the bullet and learn Go. I feel like every utility is written in it now :P |
|
Good catch! Thank you for fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415