post id avatars

[Mjokfox]

Wasn't a fan of 'gravatar', an external way to give users avatars, knowing e621 has the ability to set a post as your avatar, i wanted the same, and others might like it too so hence a pr.

since it uses user_config, it has to get the user config every time for the owner of every comment, using user_config::get_for_user($id) seemed slow as it sends a quite large event every time, so it directly gets the config in User::get_avatar_post_link(), but i am not entirely sure if its safe to do it in this way. The url or full html might also be cacheable to increase efficiency a bit thinking about it now.

[discomrade]

Hi @Mjokfox, it looks like the formatting test didn't pass. The main branch is locked down so it can't accept pull requests that don't pass the tests.

https://github.com/shish/shimmie2/actions/runs/12563091233/job/35024471162?pr=1374

The tests can be run locally, see CONTRIBUTING.md for examples.

I'd like to see this added, already looks great with those foxes.

[Mjokfox]

Thanks for the feedback! Not familiar yet with such checks, fixed it now :3

[shish]

A couple of very minor nits but yes this looks good to me :)

[shish]

(Also apologies for the delay with getting to this, I've been on a yak-shaving adventure, trying to resuscitate an abandoned library that shimmie depends upon >.>;; )

[Mjokfox]

Alright, added your suggestions.

I do still have the idea of adding a way to crop and resize the avatars using CSS, so the actual image does not need to change, while giving the user the ability to have their avatar be only part of an image. Basically store a "zoom" and "center position" in the db. I haven't tried any of that yet but I'd be willing to try and make it work if that is of any interest here as well?

[shish]

What's here now looks like a useful and stable milestone so I'mma merge as-is~

(Adding cropping sounds like it'd be nice - though I wouldn't count myself as "interested" per se, since the galleries I'm involved with already have a lot of user-investment in the gravatar approach and users are resistant to change 😅 But yeah it seems like a good thing for new installs to use)