fix(CanvasForm): Add missing ref into CustomLongTextField
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patternfly's `TextArea` component requires using a `ref` in order to provide automatic height. Unfortunately, with React function components, `ref` are not directly possible, so a workaround is needed. This commit restores the commented lines and also add the missing `ref` object. relates: KaotoIO#1043
shivamG640
reviewed
May 2, 2024
| import './CustomLongTextField.scss'; | ||
|
|
||
| export type CustomLongTextFieldProps = HTMLFieldProps<string, HTMLDivElement>; | ||
| type LongTextFieldProps = Parameters<typeof LongTextField>[0] & { ref: RefObject<HTMLTextAreaElement> }; |
There was a problem hiding this comment.
Since LongTextFieldProps is the type defined for LongTextField props and since we are adding a new property of ref to it. Giving it a new name should be the preference?
There was a problem hiding this comment.
LongTextFieldProps it's not exported from uniforms-patternfly, therefore we could use the name.
shivamG640
reviewed
May 2, 2024
| return <LongTextField className="custom-long-test-field" {...props} rows={1} autoResize={true} />; | ||
| export const CustomLongTextField: FunctionComponent<LongTextFieldProps> = (props) => { | ||
| return ( | ||
| <LongTextField className="custom-long-test-field" {...props} inputRef={props.ref} rows={1} autoResize={true} /> |
There was a problem hiding this comment.
The CustomLongField loads perfectly fine for some fields(like description) without a ref!
Why do it need a ref to load nested fields only?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Patternfly's
TextAreacomponent requires using arefto provide automatic height.Unfortunately, with React function components,
refis not directly possible, so a workaround is needed.Changes
This commit restores the commented lines and also adds the missing
refobject.relates: KaotoIO#1043