Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.5 #867

Closed
sebastianbergmann opened this issue Sep 28, 2024 · 1 comment
Closed

PHP 8.5 #867

sebastianbergmann opened this issue Sep 28, 2024 · 1 comment

Comments

@sebastianbergmann
Copy link

The PHP-8.4 branch has been created for PHP 8.4, meaning that master is now what will become PHP 8.5. It would be great if we were able to use 8.4 to reference nightly builds (until PHP 8.4.0 has been released, of course) of PHP 8.4 and 8.5 to reference nightly builds of PHP 8.5.

@shivammathur
Copy link
Owner

@sebastianbergmann
I will update the docs next week in a new release, but 8.5 should work now.

jrfnl added a commit to jrfnl/wp-cli-github that referenced this issue Oct 1, 2024
Setup-PHP has an alias available for "PHP next" named `nightly`.

While this change doesn't remove the annual task of updating the matrix when a new PHP version gets released, it does make this update a little less error prone as updating the `continue-on-error` conditions lower down in the scripts (disconnected from the matrix set up) can easily be forgotten.

There are a few caveats to keep in mind about this change though:
* Manually updating the matrix and the workflow gives (of course) more control over the exact PHP versions being used.
* When using `nightly`, that control is relinquished partially to setup-php and partially to PHP itself as `nightly` will generally always be "PHP next".
    This means that `nightly` will effectively become PHP `8.5` at the time when setup-php updates the alias, which can be at any point in time between PHP src branching off the PHP `8.4` branch (happened last week when the first RC was created) and the moment PHP `8.4` is released.
    Note: there is [some discussion going](shivammathur/setup-php#867) to clarify when "nightly" becomes "PHP next next" (`8.5`). Looks like the current intention is to not change it until PHP 8.4 has been released.

You can always check exactly what version is used for `nightly` though, by folding out the "Set up PHP environment" step and checking the PHP version listed there.

Ref:
* https://github.com/shivammathur/setup-php/?tab=readme-ov-file#php-version-optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants