Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for the embed SAPI #747

Closed
wants to merge 1 commit into from

Conversation

dunglas
Copy link

@dunglas dunglas commented Jun 28, 2023


name: 🎉 New Feature
about: Add support for the embed SAPI
labels: enhancement


Description

Attempt to support the embed SAPI to compile and test FrankenPHP with setup-php (dunglas/frankenphp#157). This could also allow using NGINX Unix with setup-php.

@dunglas
Copy link
Author

dunglas commented Jun 28, 2023

This doesn't work because the include files are not installed (/usr/local/include/php/) but are necessary to compile programs embedding PHP.

I have no idea how to fix this (and if it's something acceptable for the project). Could you give me some advice?

@shivammathur
Copy link
Owner

@dunglas

The path is /usr/include/php. That header should be present.
https://github.com/shivammathur/test-setup-php/actions/runs/5414749826/jobs/9842246653#step:3:437

@dunglas
Copy link
Author

dunglas commented Jul 3, 2023

Thanks for the hint! It works.

@dunglas dunglas closed this Jul 3, 2023
@dunglas dunglas deleted the feat/embed branch July 3, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants