Skip to content

Commit

Permalink
Enable googletest for test utils (facebookincubator#1738)
Browse files Browse the repository at this point in the history
Summary:
`velox/dwio/dwrf/test/utils/E2EWriterTestUtil.cpp` depends on googletest. Enabling `VELOX_BUILD_TEST_UTILS` now enables googletest.

Pull Request resolved: facebookincubator#1738

Reviewed By: amitkdutta

Differential Revision: D36819015

Pulled By: kgpai

fbshipit-source-id: fbe45a9c893ad78871055de68c8a0a515e3020a4
  • Loading branch information
majetideepak authored and liushengxuan committed Jul 1, 2022
1 parent 416ffd2 commit 9663ead
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,9 @@ endif()
# Benchmarks and tests at some places are coupled which is not great. See
# velox/vector/CMakeLists.txt. TODO: Decouple.
set(VELOX_DISABLE_GOOGLETEST OFF)
if(NOT VELOX_BUILD_TESTING AND NOT VELOX_ENABLE_BENCHMARKS_BASIC)
if(NOT VELOX_BUILD_TEST_UTILS
AND NOT VELOX_BUILD_TESTING
AND NOT VELOX_ENABLE_BENCHMARKS_BASIC)
set(VELOX_DISABLE_GOOGLETEST ON)
add_definitions(-DVELOX_DISABLE_GOOGLETEST)
endif()
Expand Down

0 comments on commit 9663ead

Please sign in to comment.