Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RoadRunner jobs to optionally forward a requestId as part of the task payload #61

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Apr 7, 2024

Part of shlinkio/shlink#2049

Enhance roadrunner even listeners and dispatchers so that a request id can be forwarded via roadrunner task payload.

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.56%. Comparing base (2ffb539) to head (69d871c).
Report is 2 commits behind head on main.

Files Patch % Lines
...rc/RoadRunner/RoadRunnerEventDispatcherFactory.php 85.71% 1 Missing ⚠️
...rc/RoadRunner/RoadRunnerTaskConsumerToListener.php 85.71% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##                main      #61      +/-   ##
=============================================
- Coverage     100.00%   97.56%   -2.44%     
- Complexity        27       29       +2     
=============================================
  Files              8        8              
  Lines             71       82      +11     
=============================================
+ Hits              71       80       +9     
- Misses             0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya marked this pull request as ready for review April 7, 2024 08:44
@acelaya acelaya merged commit bfdce26 into shlinkio:main Apr 7, 2024
6 checks passed
@acelaya acelaya deleted the feature/track-request-id branch April 7, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant