Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sass @imports with @use #570

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Jan 21, 2025

Replace usage of deprecated @import sass directive with @use.

@acelaya acelaya force-pushed the feature/sass-imports branch from f243c95 to de2529a Compare January 27, 2025 08:17
@acelaya acelaya changed the title Feature/sass imports Replace sass @imports with @use Jan 27, 2025
@acelaya
Copy link
Member Author

acelaya commented Jan 27, 2025

Failing tests in node 22 and 23 are due to a bug in react-router. Merging as they pass in node 20 and the rest of the checks do pass as well.

@acelaya acelaya merged commit 94788b5 into shlinkio:main Jan 27, 2025
4 of 6 checks passed
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.13%. Comparing base (567c6d7) to head (a44c3ca).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   79.13%   79.13%           
=======================================
  Files         177      177           
  Lines        7866     7866           
  Branches     1509     1509           
=======================================
  Hits         6225     6225           
  Misses        162      162           
  Partials     1479     1479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya deleted the feature/sass-imports branch January 27, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant