Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to env-var-based development config definitions #2221

Closed
acelaya opened this issue Oct 13, 2024 · 0 comments · Fixed by #2224
Closed

Switch to env-var-based development config definitions #2221

acelaya opened this issue Oct 13, 2024 · 0 comments · Fixed by #2224
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Oct 13, 2024

Once #2220 is merged, we will have moved the default values for env vars to EnvVars enum.

This means we could remove most of the local dev config files (at least those that map to options objects), and instead use env vars for custom values in development as well, by using a .env file that's loaded via docker compose, for example.

This will also allow to read env vars anywhere, rather than having to remember the value should be set in config files only, and also ensure the env-var:read command returns consistent values in dev environments as well.

Additionally, we could remove the dependency that is used to map options objects from config, and instead read env vars directly to set their default values.

@acelaya acelaya added this to the 4.3.0 milestone Oct 13, 2024
@acelaya acelaya added this to Shlink Oct 13, 2024
@acelaya acelaya changed the title Switch to env-var-based development config definition Switch to env-var-based development config definitions Oct 13, 2024
@acelaya acelaya moved this to Todo in Shlink Oct 13, 2024
@acelaya acelaya moved this from Todo to In Progress in Shlink Oct 24, 2024
@acelaya acelaya moved this from In Progress to In review in Shlink Oct 24, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink Oct 24, 2024
@acelaya acelaya modified the milestones: 4.3.0, 4.2.4 Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant