-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate dev-specific configuration to env vars via .env file #2224
Merged
acelaya
merged 15 commits into
shlinkio:develop
from
acelaya-forks:feature/dev-config-as-env
Oct 24, 2024
Merged
Migrate dev-specific configuration to env vars via .env file #2224
acelaya
merged 15 commits into
shlinkio:develop
from
acelaya-forks:feature/dev-config-as-env
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
force-pushed
the
feature/dev-config-as-env
branch
4 times, most recently
from
October 21, 2024 10:03
c2e1cf1
to
ee81dc7
Compare
acelaya
force-pushed
the
feature/dev-config-as-env
branch
from
October 22, 2024 13:16
ee81dc7
to
c8e5196
Compare
acelaya
force-pushed
the
feature/dev-config-as-env
branch
from
October 23, 2024 08:16
c12279e
to
442eea0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2224 +/- ##
=============================================
- Coverage 94.84% 93.50% -1.34%
- Complexity 1592 1607 +15
=============================================
Files 270 270
Lines 5527 5608 +81
=============================================
+ Hits 5242 5244 +2
- Misses 285 364 +79 ☔ View full report in Codecov by Sentry. |
acelaya
force-pushed
the
feature/dev-config-as-env
branch
from
October 24, 2024 09:44
6bb33fb
to
f969433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2221
This PR updates how dev/local configuration is handled by Shlink, to use env vars defined in env-specific files rather than local configuration files that overwrite global ones.
.local
config filesloadEnvVarsFromConfig
.