Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Target Events plugin #117

Closed
DrDonkeyPunch opened this issue Sep 28, 2020 · 1 comment
Closed

Issues with Target Events plugin #117

DrDonkeyPunch opened this issue Sep 28, 2020 · 1 comment
Assignees
Labels
comp: core-plugins @pebula/ngrid/* (All things related to core plugins the come as secondary package in @pebula/ngrid) type: bug/fix
Milestone

Comments

@DrDonkeyPunch
Copy link

Hello,

First of all, thanks for the great work on the lib.

I've been trying to use the Target Events on a grid in my project to provide an Excel like experience when navigating with the keyboard. I encountered some unexpected behaviors :

  1. When you rapidly press the down arrow key twice, the next cell appears selected rather than focused
  2. If you repeat the previous case multiple times, the focus sometimes jumps several rows (5-6 rows jumps in my case)
  3. When you play with long press and short press on the down / up arrow key, you end up losing the focused cell. You can still go up and down the grid but the focused cell is not visible.
  4. Once you've reached the bottom of the grid, any additionnal down arrow key pressing will scroll the main page. If you then press the up arrow key, you can scroll the grid but the main page won't scroll back to where it was.

I succesfully reproduced all these cases on the demo website.

Thanks

@shlomiassaf
Copy link
Owner

shlomiassaf commented Sep 28, 2020

Hi @DrDonkeyPunch

Thanks for the update

I guess 1 & 2 both manifest in 3 and are all probably the same issue.
I will look into it once I have time, if you want to jump in fell free, all help is appreciated.

As for 4, I guess that's the default behaviour of the underlaying components, I will check it as well.

Edit: Issue is related to virtual scroll, will happen when rapid clicking and the rapid click caused virtual scroll row rendering

@shlomiassaf shlomiassaf added comp: core-plugins @pebula/ngrid/* (All things related to core plugins the come as secondary package in @pebula/ngrid) type: bug/fix labels Sep 28, 2020
@shlomiassaf shlomiassaf added this to the 2.x.x milestone Sep 28, 2020
@shlomiassaf shlomiassaf modified the milestones: 2.x.x, 3.0.0 Nov 10, 2020
@shlomiassaf shlomiassaf added the V3 label Nov 10, 2020
@shlomiassaf shlomiassaf self-assigned this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: core-plugins @pebula/ngrid/* (All things related to core plugins the come as secondary package in @pebula/ngrid) type: bug/fix
Projects
None yet
Development

No branches or pull requests

2 participants