Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3] refactor group columns #131

Closed
shlomiassaf opened this issue Nov 2, 2020 · 0 comments
Closed

[V3] refactor group columns #131

shlomiassaf opened this issue Nov 2, 2020 · 0 comments
Assignees
@shlomiassaf
Labels
comp: core @pebula/ngrid (core package only, excluding secondary packages) has PR
Milestone
3.0.0

Comments

@shlomiassaf
Copy link
Owner

Instead of using prop and span to define column group, use a different way so columns that are not siblings can share the same group. (currently only supported after init, using dragging)

We should use something like columnId list.

the prop/span method should be deprecated and removed in v4.
@shlomiassaf shlomiassaf changed the title refactor group columns [V3] refactor group columns Nov 2, 2020
@shlomiassaf shlomiassaf added this to the 3.0.0 milestone Nov 2, 2020
@shlomiassaf shlomiassaf self-assigned this Nov 10, 2020
@shlomiassaf shlomiassaf added comp: core @pebula/ngrid (core package only, excluding secondary packages) V3 has PR labels Nov 10, 2020
shlomiassaf added a commit that referenced this issue Nov 15, 2020
@shlomiassaf
refactor(ngrid): refactor the cell rendering engine and refactor the …
35cb147 
…group definitions

Closes #123
Closes #131

BREAKING CHANGE:
`prop` and `span` are deprecated from `PblColumnGroupDefinition` and will be removed from version 4.0.0

`prop` and `span` are removed from `PblColumnGroup` and instread columnIds list is used
shlomiassaf added a commit that referenced this issue Nov 15, 2020
@shlomiassaf
refactor(ngrid): refactor the cell rendering engine and refactor the …
504b849 
…group definitions

Closes #123
Closes #131

BREAKING CHANGE:
`prop` and `span` are deprecated from `PblColumnGroupDefinition` and will be removed from version 4.0.0

`prop` and `span` are removed from `PblColumnGroup` and instread columnIds list is used
shlomiassaf added a commit that referenced this issue Nov 16, 2020
@shlomiassaf
refactor(ngrid): refactor the cell rendering engine and refactor the …
46d6578 
…group definitions

Closes #123
Closes #131

BREAKING CHANGE:
`prop` and `span` are deprecated from `PblColumnGroupDefinition` and will be removed from version 4.0.0

`prop` and `span` are removed from `PblColumnGroup` and instread columnIds list is used
shlomiassaf added a commit that referenced this issue Dec 3, 2020
@shlomiassaf
refactor(ngrid): refactor the cell rendering engine and refactor the …
4882e4a 
…group definitions

Closes #123
Closes #131

BREAKING CHANGE:
`prop` and `span` are deprecated from `PblColumnGroupDefinition` and will be removed from version 4.0.0

`prop` and `span` are removed from `PblColumnGroup` and instread columnIds list is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlomiassaf shlomiassaf

Labels
comp: core @pebula/ngrid (core package only, excluding secondary packages) has PR
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@shlomiassaf