Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changed style to minimum support of RTL language #768

Merged
merged 1 commit into from
Jun 1, 2022
Merged

refactor: changed style to minimum support of RTL language #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/alert/alert.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default css`
display: flex;
align-items: center;
font-size: var(--sl-font-size-large);
padding-left: var(--sl-spacing-large);
padding-inline-start: var(--sl-spacing-large);
}

.alert--primary {
Expand Down Expand Up @@ -92,6 +92,6 @@ export default css`
display: flex;
align-items: center;
font-size: var(--sl-font-size-large);
padding-right: var(--sl-spacing-medium);
padding-inline-end: var(--sl-spacing-medium);
}
`;
4 changes: 2 additions & 2 deletions src/components/breadcrumb-item/breadcrumb-item.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@ export default css`

.breadcrumb-item--has-prefix .breadcrumb-item__prefix {
display: inline-flex;
margin-right: var(--sl-spacing-x-small);
margin-inline-end: var(--sl-spacing-x-small);
}

.breadcrumb-item--has-suffix .breadcrumb-item__suffix {
display: inline-flex;
margin-left: var(--sl-spacing-x-small);
margin-inline-start: var(--sl-spacing-x-small);
}

:host(:last-of-type) .breadcrumb-item__separator {
Expand Down
38 changes: 20 additions & 18 deletions src/components/button/button.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,57 +473,57 @@ export default css`
}

.button--has-prefix.button--small {
padding-left: var(--sl-spacing-x-small);
padding-inline-start: var(--sl-spacing-x-small);
}

.button--has-prefix.button--small .button__label {
padding-left: var(--sl-spacing-x-small);
padding-inline-start: var(--sl-spacing-x-small);
}

.button--has-prefix.button--medium {
padding-left: var(--sl-spacing-small);
padding-inline-start: var(--sl-spacing-small);
}

.button--has-prefix.button--medium .button__label {
padding-left: var(--sl-spacing-small);
padding-inline-start: var(--sl-spacing-small);
}

.button--has-prefix.button--large {
padding-left: var(--sl-spacing-small);
padding-inline-start: var(--sl-spacing-small);
}

.button--has-prefix.button--large .button__label {
padding-left: var(--sl-spacing-small);
padding-inline-start: var(--sl-spacing-small);
}

.button--has-suffix.button--small,
.button--caret.button--small {
padding-right: var(--sl-spacing-x-small);
padding-inline-end: var(--sl-spacing-x-small);
}

.button--has-suffix.button--small .button__label,
.button--caret.button--small .button__label {
padding-right: var(--sl-spacing-x-small);
padding-inline-end: var(--sl-spacing-x-small);
}

.button--has-suffix.button--medium,
.button--caret.button--medium {
padding-right: var(--sl-spacing-small);
padding-inline-end: var(--sl-spacing-small);
}

.button--has-suffix.button--medium .button__label,
.button--caret.button--medium .button__label {
padding-right: var(--sl-spacing-small);
padding-inline-end: var(--sl-spacing-small);
}

.button--has-suffix.button--large,
.button--caret.button--large {
padding-right: var(--sl-spacing-small);
padding-inline-end: var(--sl-spacing-small);
}

.button--has-suffix.button--large .button__label,
.button--caret.button--large .button__label {
padding-right: var(--sl-spacing-small);
padding-inline-end: var(--sl-spacing-small);
}

/*
Expand All @@ -534,22 +534,24 @@ export default css`
*/

:host(.sl-button-group__button--first:not(.sl-button-group__button--last)) .button {
border-top-right-radius: 0;
border-bottom-right-radius: 0;
border-inline-end-width: 0;
/* border-top-right-radius: 0; */
/* border-bottom-right-radius: 0; */
}

:host(.sl-button-group__button--inner) .button {
border-radius: 0;
}

:host(.sl-button-group__button--last:not(.sl-button-group__button--first)) .button {
border-top-left-radius: 0;
border-bottom-left-radius: 0;
border-start-start-radius: 0;
/* border-top-left-radius: 0;
border-bottom-left-radius: 0; */
}

/* All except the first */
:host(.sl-button-group__button:not(.sl-button-group__button--first)) {
margin-left: calc(-1 * var(--sl-input-border-width));
margin-inline-start: calc(-1 * var(--sl-input-border-width));
}

/* Add a visual separator between solid buttons */
Expand All @@ -560,7 +562,7 @@ export default css`
top: 0;
left: 0;
bottom: 0;
border-left: solid 1px rgb(128 128 128 / 33%);
border-inline-start-style: solid 1px rgb(128 128 128 / 33%);
mix-blend-mode: multiply;
}

Expand Down
2 changes: 1 addition & 1 deletion src/components/checkbox/checkbox.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export default css`

.checkbox__label {
line-height: var(--sl-toggle-size);
margin-left: 0.5em;
margin-inline-start: 0.5em;
user-select: none;
}
`;
2 changes: 1 addition & 1 deletion src/components/dialog/dialog.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export default css`
}

.dialog__footer ::slotted(sl-button:not(:first-of-type)) {
margin-left: var(--sl-spacing-x-small);
margin-inline-start: var(--sl-spacing-x-small);
}

.dialog:not(.dialog--has-footer) .dialog__footer {
Expand Down
2 changes: 1 addition & 1 deletion src/components/drawer/drawer.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export default css`
}

.drawer__footer ::slotted(sl-button:not(:last-of-type)) {
margin-right: var(--sl-spacing-x-small);
margin-inline-end: var(--sl-spacing-x-small);
}

.drawer:not(.drawer--has-footer) .drawer__footer {
Expand Down
12 changes: 6 additions & 6 deletions src/components/input/input.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,11 @@ export default css`
}

.input--small .input__prefix ::slotted(*) {
padding-left: var(--sl-input-spacing-small);
padding-inline-start: var(--sl-input-spacing-small);
}

.input--small .input__suffix ::slotted(*) {
padding-right: var(--sl-input-spacing-small);
padding-inline-end: var(--sl-input-spacing-small);
}

.input--medium {
Expand All @@ -198,11 +198,11 @@ export default css`
}

.input--medium .input__prefix ::slotted(*) {
padding-left: var(--sl-input-spacing-medium);
padding-inline-start: var(--sl-input-spacing-medium);
}

.input--medium .input__suffix ::slotted(*) {
padding-right: var(--sl-input-spacing-medium);
padding-inline-end: var(--sl-input-spacing-medium);
}

.input--large {
Expand All @@ -222,11 +222,11 @@ export default css`
}

.input--large .input__prefix ::slotted(*) {
padding-left: var(--sl-input-spacing-large);
padding-inline-start: var(--sl-input-spacing-large);
}

.input--large .input__suffix ::slotted(*) {
padding-right: var(--sl-input-spacing-large);
padding-inline-end: var(--sl-input-spacing-large);
}

/*
Expand Down
5 changes: 2 additions & 3 deletions src/components/menu-item/menu-item.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export default css`
font-weight: var(--sl-font-weight-normal);
line-height: var(--sl-line-height-normal);
letter-spacing: var(--sl-letter-spacing-normal);
text-align: left;
color: var(--sl-color-neutral-700);
padding: var(--sl-spacing-2x-small) var(--sl-spacing-2x-small);
transition: var(--sl-transition-fast) fill;
Expand All @@ -44,7 +43,7 @@ export default css`
}

.menu-item .menu-item__prefix ::slotted(*) {
margin-right: var(--sl-spacing-x-small);
margin-inline-end: var(--sl-spacing-x-small);
}

.menu-item .menu-item__suffix {
Expand All @@ -54,7 +53,7 @@ export default css`
}

.menu-item .menu-item__suffix ::slotted(*) {
margin-left: var(--sl-spacing-x-small);
margin-inline-start: var(--sl-spacing-x-small);
}

:host(:focus) {
Expand Down
2 changes: 1 addition & 1 deletion src/components/radio/radio.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export default css`

.radio__label {
line-height: var(--sl-toggle-size);
margin-left: 0.5em;
margin-inline-start: 0.5em;
user-select: none;
}
`;
2 changes: 1 addition & 1 deletion src/components/range/range.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export default css`
width: 0;
height: 0;
left: 50%;
margin-left: calc(-1 * var(--sl-tooltip-arrow-size));
margin-inline-start: calc(-1 * var(--sl-tooltip-arrow-size));
}

.range--tooltip-visible .range__tooltip {
Expand Down
38 changes: 19 additions & 19 deletions src/components/select/select.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export default css`
align-items: center;
flex-wrap: wrap;
justify-content: left;
margin-left: var(--sl-spacing-2x-small);
margin-inline-start: var(--sl-spacing-2x-small);
}

/* Hidden input (for form control validation to show) */
Expand Down Expand Up @@ -194,23 +194,23 @@ export default css`
}

.select--small .select__prefix ::slotted(*) {
margin-left: var(--sl-input-spacing-small);
margin-inline-start: var(--sl-input-spacing-small);
}

.select--small .select__label {
margin: 0 var(--sl-input-spacing-small);
}

.select--small .select__clear {
margin-right: var(--sl-input-spacing-small);
margin-inline-end: var(--sl-input-spacing-small);
}

.select--small .select__suffix ::slotted(*) {
margin-right: var(--sl-input-spacing-small);
margin-inline-end: var(--sl-input-spacing-small);
}

.select--small .select__icon {
margin-right: var(--sl-input-spacing-small);
margin-inline-end: var(--sl-input-spacing-small);
}

.select--small .select__tags {
Expand All @@ -222,11 +222,11 @@ export default css`
}

.select--small .select__tags sl-tag:not(:last-of-type) {
margin-right: var(--sl-spacing-2x-small);
margin-inline-end: var(--sl-spacing-2x-small);
}

.select--small.select--has-tags .select__label {
margin-left: 0;
margin-inline-start: 0;
}

/* Medium */
Expand All @@ -237,23 +237,23 @@ export default css`
}

.select--medium .select__prefix ::slotted(*) {
margin-left: var(--sl-input-spacing-medium);
margin-inline-start: var(--sl-input-spacing-medium);
}

.select--medium .select__label {
margin: 0 var(--sl-input-spacing-medium);
}

.select--medium .select__clear {
margin-right: var(--sl-input-spacing-medium);
margin-inline-end: var(--sl-input-spacing-medium);
}

.select--medium .select__suffix ::slotted(*) {
margin-right: var(--sl-input-spacing-medium);
margin-inline-end: var(--sl-input-spacing-medium);
}

.select--medium .select__icon {
margin-right: var(--sl-input-spacing-medium);
margin-inline-end: var(--sl-input-spacing-medium);
}

.select--medium .select__tags {
Expand All @@ -265,11 +265,11 @@ export default css`
}

.select--medium .select__tags sl-tag:not(:last-of-type) {
margin-right: var(--sl-spacing-2x-small);
margin-inline-end: var(--sl-spacing-2x-small);
}

.select--medium.select--has-tags .select__label {
margin-left: 0;
margin-inline-start: 0;
}

/* Large */
Expand All @@ -280,23 +280,23 @@ export default css`
}

.select--large .select__prefix ::slotted(*) {
margin-left: var(--sl-input-spacing-large);
margin-inline-start: var(--sl-input-spacing-large);
}

.select--large .select__label {
margin: 0 var(--sl-input-spacing-large);
}

.select--large .select__clear {
margin-right: var(--sl-input-spacing-large);
margin-inline-end: var(--sl-input-spacing-large);
}

.select--large .select__suffix ::slotted(*) {
margin-right: var(--sl-input-spacing-large);
margin-inline-end: var(--sl-input-spacing-large);
}

.select--large .select__icon {
margin-right: var(--sl-input-spacing-large);
margin-inline-end: var(--sl-input-spacing-large);
}

.select--large .select__tags {
Expand All @@ -307,11 +307,11 @@ export default css`
}

.select--large .select__tags sl-tag:not(:last-of-type) {
margin-right: var(--sl-spacing-2x-small);
margin-inline-end: var(--sl-spacing-2x-small);
}

.select--large.select--has-tags .select__label {
margin-left: 0;
margin-inline-start: 0;
}

/*
Expand Down
2 changes: 1 addition & 1 deletion src/components/switch/switch.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export default css`

.switch__label {
line-height: var(--height);
margin-left: 0.5em;
margin-inline-start: 0.5em;
user-select: none;
}
`;
Loading