Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: expectation always comes first #44

Merged
merged 3 commits into from
Sep 24, 2022
Merged

Conversation

shoenig
Copy link
Owner

@shoenig shoenig commented Sep 24, 2022

This PR introduces breaking changes, where less/greater helpers now
have the expectation come first. This is to be more consistent with
other functions.

Closes #33

This PR introduces breaking changes, where less/greater helpers now
have the expectation come first. This is to be more consistent with
other functions.
@shoenig shoenig merged commit f8db391 into main Sep 24, 2022
@shoenig shoenig deleted the b-greater-less-order branch December 15, 2023 15:17
@HeCorr
Copy link

HeCorr commented Mar 9, 2024

I'm wondering why this and so many other test packages use this convention of expected, actual where actual, expected is significantly more readable in my opinion ("expect actual to be expected" / if actual == expected).

@shoenig
Copy link
Owner Author

shoenig commented Mar 9, 2024

Hi @HeCorr it's a good question.

My best guess is the convention was solidified by JUnit a long, long time ago, e.g. assertEquals and nobody wants to break with convention because at this point it's just what folks expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: parameters for greater/less functions are backwards
2 participants