fix response type

shogo82148 · Jan 29, 2020 · 8ba1b3d · 8ba1b3d
1 parent 2e0e5f0
commit 8ba1b3d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/__tests__/main.test.ts b/__tests__/main.test.ts
@@ -2,7 +2,7 @@ import {upload} from '../src/upload-release-asset'
 
 test('Upload Release Asset', async () => {
   const uploadReleaseAsset = jest.fn().mockReturnValue({
-    data: {value: {browser_download_url: 'http://example.com/download'}}
+    data: {browser_download_url: 'http://example.com/download'}
   })
   const github = {
     repos: {
@@ -33,7 +33,7 @@ test('Upload Release Asset', async () => {
 
 test('Upload Multiple Files', async () => {
   const uploadReleaseAsset = jest.fn().mockReturnValue({
-    data: {value: {browser_download_url: 'http://example.com/download'}}
+    data: {browser_download_url: 'http://example.com/download'}
   })
   const github = {
     repos: {
@@ -84,7 +84,7 @@ test('Upload Multiple Files', async () => {
 
 test('Guess Content Types', async () => {
   const uploadReleaseAsset = jest.fn().mockReturnValue({
-    data: {value: {browser_download_url: 'http://example.com/download'}}
+    data: {browser_download_url: 'http://example.com/download'}
   })
   const github = {
     repos: {

diff --git a/src/main.ts b/src/main.ts
@@ -10,7 +10,10 @@ async function run(): Promise<void> {
     const asset_name = core.getInput('asset_name')
     const asset_content_type = core.getInput('asset_content_type')
 
-    const github = new GitHub(github_token)
+    // bug? ReposUploadReleaseAssetResponse doesn't match actual response.
+    // so ignore types
+    const github = new GitHub(github_token) as any
+
     const output = await upload({
       github,
       upload_url,

diff --git a/src/upload-release-asset.ts b/src/upload-release-asset.ts
@@ -21,9 +21,6 @@ interface Response<T> {
   data: T
 }
 interface ReposUploadReleaseAssetResponse {
-  value: ReposUploadReleaseAssetResponseValue
-}
-interface ReposUploadReleaseAssetResponseValue {
   browser_download_url: string
 }
 interface GitHubRepos {
@@ -67,7 +64,7 @@ export async function upload(opts: Options): Promise<Outputs> {
         file: fs.readFileSync(file)
       })
       core.debug(JSON.stringify(response))
-      return response.data.value.browser_download_url
+      return response.data.browser_download_url
     })
   )
   return {