add mingw-x64 to test matrix

.github/install-mecab-darwin.sh

@@ -7,15 +7,15 @@ set -uxe
 TMPDIR=$(mktemp -d)
 trap 'rm -rfv "$TMPDIR"' EXIT
 
-MECAB_VERSION=0.996.2
+MECAB_VERSION=0.996.4
 IPADIC_VERSION=2.7.0-20070801
 # install mecab
 cd "$TMPDIR"
 curl -o mecab.tar.gz -sSL "https://github.com/shogo82148/mecab/releases/download/v$MECAB_VERSION/mecab-$MECAB_VERSION.tar.gz"
 tar zxfv mecab.tar.gz
 cd "mecab-$MECAB_VERSION"
 ./configure --enable-utf8-only
-make
+make -j2
 make check
 sudo make install
 

.github/install-mecab-linux.sh

@@ -7,15 +7,15 @@ set -uxe
 TMPDIR=$(mktemp -d)
 trap 'rm -rfv "$TMPDIR"' EXIT
 
-MECAB_VERSION=0.996.2
+MECAB_VERSION=0.996.4
 IPADIC_VERSION=2.7.0-20070801
 # install mecab
 cd "$TMPDIR"
 curl -o mecab.tar.gz -sSL "https://github.com/shogo82148/mecab/releases/download/v$MECAB_VERSION/mecab-$MECAB_VERSION.tar.gz"
 tar zxfv mecab.tar.gz
 cd "mecab-$MECAB_VERSION"
 ./configure --enable-utf8-only
-make
+make -j2
 make check
 sudo make install
 sudo ldconfig

.github/install-mecab-mingw.sh

@@ -0,0 +1,42 @@
+#!/bin/bash
+# from https://gist.github.com/dtan4/351d031bec0c3d45cd8f
+# see also http://qiita.com/dtan4/items/c6a087666296fbd5fffb
+
+set -uxe
+
+TMPDIR=$(mktemp -d)
+trap 'rm -rfv "$TMPDIR"' EXIT
+
+MECAB_VERSION=0.996.4
+IPADIC_VERSION=2.7.0-20070801
+# install mecab
+cd "$TMPDIR"
+curl -o mecab.tar.gz -sSL "https://github.com/shogo82148/mecab/releases/download/v$MECAB_VERSION/mecab-$MECAB_VERSION.tar.gz"
+tar zxfv mecab.tar.gz
+cd "mecab-$MECAB_VERSION"
+./configure --enable-utf8-only --host=x86_64-w64-mingw32
+make -j2
+# make check # it fails :(
+make install
+
+cd "$TMPDIR"
+curl -o mecab-ipadic.tar.gz -sSL "https://github.com/shogo82148/mecab/releases/download/v$MECAB_VERSION/mecab-ipadic-$IPADIC_VERSION.tar.gz"
+tar zxfv mecab-ipadic.tar.gz
+cd "mecab-ipadic-$IPADIC_VERSION"
+./configure --with-charset=utf8
+make
+make install
+
+{
+    echo "CGO_LDFLAGS=-L$(cygpath -w /mingw64/lib) -lmecab -lstdc++"
+    echo "CGO_CFLAGS=-I$(cygpath -w /mingw64/include)"
+} >> "$GITHUB_ENV"
+
+cat << DIC > /mingw64/etc/mecabrc
+dicdir = $(cygpath -w /mingw64/lib/mecab/dic/ipadic)
+DIC
+
+# The default mecabrc path is "C:\Program Files\mecab\etc\mecabrc" if mecab is built with mingw32-w64.
+# but it is not correct in MSYS2 environment.
+echo "MECABRC_PATH=$(cygpath -w /mingw64/etc/mecabrc)" >> "$GITHUB_ENV"
+cygpath -w /mingw64/bin >> "$GITHUB_PATH"

.github/workflows/test.yml

@@ -60,3 +60,33 @@ jobs:
         run: |
           go version
           go test -v -race ./...
+
+  mingw:
+    strategy:
+      matrix:
+        go:
+          - "1"
+          - "1.15"
+          - "1.14"
+          - "1.13"
+          - "1.12"
+      fail-fast: false
+    runs-on: windows-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: setup Go ${{ matrix.go }}
+        uses: actions/setup-go@v2
+        with:
+          go-version: ${{ matrix.go }}
+      - uses: msys2/setup-msys2@v2
+        with:
+          install: autoconf bison make automake1.16 automake-wrapper mingw-w64-x86_64-gcc mingw-w64-x86_64-libtool mingw-w64-x86_64-libiconv
+
+      - name: install mecab
+        run: |
+          .github/install-mecab-mingw.sh
+        shell: msys2 {0}
+      - name: test
+        run: |
+          go version
+          go test -v ./...

example_test.go

@@ -2,12 +2,18 @@ package mecab_test
 
 import (
 	"fmt"
+	"os"
 
 	"github.com/shogo82148/go-mecab"
 )
 
 func ExampleMeCab_Parse() {
-	tagger, err := mecab.New(map[string]string{})
+	options := map[string]string{}
+	if path := os.Getenv("MECABRC_PATH"); path != "" {
+		options["rcfile"] = path
+	}
+
+	tagger, err := mecab.New(options)
 	if err != nil {
 		panic(err)
 	}
@@ -25,7 +31,12 @@ func ExampleMeCab_Parse() {
 }
 
 func ExampleMeCab_ParseLattice() {
-	tagger, err := mecab.New(map[string]string{})
+	options := map[string]string{}
+	if path := os.Getenv("MECABRC_PATH"); path != "" {
+		options["rcfile"] = path
+	}
+
+	tagger, err := mecab.New(options)
 	if err != nil {
 		panic(err)
 	}
@@ -49,7 +60,12 @@ func ExampleMeCab_ParseLattice() {
 }
 
 func ExampleMeCab_ParseToNode() {
-	tagger, err := mecab.New(map[string]string{})
+	options := map[string]string{}
+	if path := os.Getenv("MECABRC_PATH"); path != "" {
+		options["rcfile"] = path
+	}
+
+	tagger, err := mecab.New(options)
 	if err != nil {
 		panic(err)
 	}

mecab.go

@@ -8,8 +8,8 @@ import (
 	"errors"
 	"fmt"
 	"reflect"
-	"unsafe"
 	"runtime"
+	"unsafe"
 )
 
 // MeCab is a morphological parser.
@@ -39,10 +39,15 @@ func New(args map[string]string) (MeCab, error) {
 		opts = append(opts, opt)
 	}
 
+	// C.mecab_new sets an error in the thread local storage.
+	// so C.mecab_new and C.mecab_strerror must be call in same thread.
+	runtime.LockOSThread()
+	defer runtime.UnlockOSThread()
+
 	// create new MeCab
 	mecab := C.mecab_new(C.int(len(opts)), (**C.char)(&opts[0]))
 	if mecab == nil {
-		return MeCab{}, errors.New("mecab: mecab is not created")
+		return MeCab{}, errors.New(C.GoString(C.mecab_strerror(nil)))
 	}
 
 	return MeCab{

mecab_test.go

@@ -1,9 +1,31 @@
 package mecab
 
-import "testing"
+import (
+	"os"
+	"testing"
+)
+
+var mecabrcPath string
+
+func init() {
+	// get mecabrc path from mecab-config from the environment value.
+	if path := os.Getenv("MECABRC_PATH"); path != "" {
+		mecabrcPath = path
+	}
+}
+
+func rcfile(config map[string]string) map[string]string {
+	if mecabrcPath != "" {
+		config["rcfile"] = mecabrcPath
+	}
+	return config
+}
 
 func TestNewMeCab(t *testing.T) {
-	mecab, err := New(map[string]string{"output-format-type": "wakati", "all-morphs": ""})
+	mecab, err := New(rcfile(map[string]string{
+		"output-format-type": "wakati",
+		"all-morphs": "",
+	}))
 	if err != nil {
 		t.Errorf("unexpected error: %v", err)
 		return
@@ -12,7 +34,9 @@ func TestNewMeCab(t *testing.T) {
 }
 
 func TestParse(t *testing.T) {
-	mecab, err := New(map[string]string{"output-format-type": "wakati"})
+	mecab, err := New(rcfile(map[string]string{
+		"output-format-type": "wakati",
+	}))
 	if err != nil {
 		t.Errorf("unexpected error: %v", err)
 		return
@@ -31,7 +55,9 @@ func TestParse(t *testing.T) {
 }
 
 func BenchmarkParse(b *testing.B) {
-	mecab, _ := New(map[string]string{"output-format-type": "wakati"})
+	mecab, _ := New(rcfile(map[string]string{
+		"output-format-type": "wakati",
+	}))
 	defer mecab.Destroy()
 
 	for i := 0; i < b.N; i++ {
@@ -40,7 +66,9 @@ func BenchmarkParse(b *testing.B) {
 }
 
 func TestParseLattice(t *testing.T) {
-	mecab, err := New(map[string]string{"output-format-type": "wakati"})
+	mecab, err := New(rcfile(map[string]string{
+		"output-format-type": "wakati",
+	}))
 	if err != nil {
 		t.Errorf("unexpected error: %v", err)
 		return
@@ -69,7 +97,9 @@ func TestParseLattice(t *testing.T) {
 }
 
 func BenchmarkParseLattice(b *testing.B) {
-	mecab, _ := New(map[string]string{"output-format-type": "wakati"})
+	mecab, _ := New(rcfile(map[string]string{
+		"output-format-type": "wakati",
+	}))
 	defer mecab.Destroy()
 
 	lattice, _ := NewLattice()
@@ -83,7 +113,8 @@ func BenchmarkParseLattice(b *testing.B) {
 }
 
 func TestParseToNode(t *testing.T) {
-	mecab, err := New(map[string]string{})
+	mecab, err := New(rcfile(map[string]string{
+	}))
 	if err != nil {
 		t.Errorf("unexpected error: %v", err)
 		return
@@ -109,7 +140,8 @@ func TestParseToNode(t *testing.T) {
 }
 
 func BenchmarkParseToNode(b *testing.B) {
-	mecab, _ := New(map[string]string{})
+	mecab, _ := New(rcfile(map[string]string{
+	}))
 	defer mecab.Destroy()
 
 	// XXX: avoid GC, MeCab 0.996 has GC problem (see https://github.com/taku910/mecab/pull/24)

model.go

@@ -6,6 +6,7 @@ import "C"
 import (
 	"errors"
 	"fmt"
+	"runtime"
 	"unsafe"
 )
 
@@ -36,10 +37,15 @@ func NewModel(args map[string]string) (Model, error) {
 		opts = append(opts, opt)
 	}
 
+	// C.mecab_model_new sets an error in the thread local storage.
+	// so C.mecab_model_new and C.mecab_strerror must be call in same thread.
+	runtime.LockOSThread()
+	defer runtime.UnlockOSThread()
+
 	// create new MeCab model
 	model := C.mecab_model_new(C.int(len(opts)), (**C.char)(&opts[0]))
 	if model == nil {
-		return Model{}, errors.New("mecab: mecab_model is not created")
+		return Model{}, errors.New(C.GoString(C.mecab_strerror(nil)))
 	}
 
 	return Model{

model_test.go

@@ -3,7 +3,9 @@ package mecab
 import "testing"
 
 func TestModel(t *testing.T) {
-	model, err := NewModel(map[string]string{"output-format-type": "wakati"})
+	model, err := NewModel(rcfile(map[string]string{
+		"output-format-type": "wakati",
+	}))
 	if err != nil {
 		t.Errorf("unexpected error: %v", err)
 		return