Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Ruby 3.4.0 to the build matrix #127

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

shogo82148
Copy link
Owner

@shogo82148 shogo82148 commented Dec 25, 2024

Summary by CodeRabbit

  • New Features
    • Added support for Ruby 3.4 in the testing workflows for both macOS and Linux environments.
  • Bug Fixes
    • Enhanced testing coverage by including an additional Ruby version in the testing matrix.

Copy link

coderabbitai bot commented Dec 25, 2024

Walkthrough

The pull request updates GitHub Actions workflows for Ruby testing on both macOS and Linux platforms by introducing Ruby version 3.4 to the testing matrix. This change expands the range of Ruby versions tested in the continuous integration pipeline, ensuring compatibility with the latest Ruby release across different operating systems.

Changes

File Change Summary
.github/workflows/test-darwin-ruby.yml Added Ruby 3.4 to macOS testing matrix
.github/workflows/test-linux-ruby.yml Added Ruby 3.4 to Linux testing matrix

Poem

🐰 A Ruby update hops along the way,
Testing workflows expand today!
Version 3.4 joins the test parade,
On macOS and Linux, tests are made
Continuous integration's new delight! 🧪


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between adc633b and c05ef9c.

📒 Files selected for processing (2)
  • .github/workflows/test-darwin-ruby.yml (1 hunks)
  • .github/workflows/test-linux-ruby.yml (1 hunks)
🔇 Additional comments (2)
.github/workflows/test-linux-ruby.yml (1)

23-23: LGTM! Verify runner compatibility with Ruby 3.4

The addition of Ruby 3.4 to the matrix is correct and follows the existing pattern. The version is appropriately placed at the top of the list, maintaining the descending order.

Let's verify the compatibility of Ruby 3.4 with the ubuntu-latest runner:

✅ Verification successful

Ruby 3.4 is compatible with ubuntu-latest runner

The workflow has been successfully executed on the main branch with Ruby 3.4 in the matrix, confirming compatibility with the ubuntu-latest runner.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the workflow has been run successfully with Ruby 3.4

gh run list --workflow=test-linux-ruby.yml --json conclusion,headBranch,status --jq '.[] | select(.headBranch=="main" or .headBranch=="refs/heads/main") | select(.status=="completed") | .conclusion' | head -n 1

Length of output: 220

.github/workflows/test-darwin-ruby.yml (1)

23-24: LGTM! Matrix configuration is consistent

The addition of Ruby 3.4 with macos-latest runner is correct and maintains consistency with:

  • The existing pattern where newer Ruby versions use macos-latest
  • The parallel change in the Linux workflow

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shogo82148 shogo82148 merged commit 3bcc2aa into main Dec 25, 2024
25 checks passed
@shogo82148 shogo82148 deleted the ruby-3.4.0-is-released branch December 25, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant