-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Ruby 3.4.0 to the build matrix #127
Conversation
WalkthroughThe pull request updates GitHub Actions workflows for Ruby testing on both macOS and Linux platforms by introducing Ruby version 3.4 to the testing matrix. This change expands the range of Ruby versions tested in the continuous integration pipeline, ensuring compatibility with the latest Ruby release across different operating systems. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (2).github/workflows/test-linux-ruby.yml (1)
The addition of Ruby 3.4 to the matrix is correct and follows the existing pattern. The version is appropriately placed at the top of the list, maintaining the descending order. Let's verify the compatibility of Ruby 3.4 with the ubuntu-latest runner: ✅ Verification successfulRuby 3.4 is compatible with ubuntu-latest runner The workflow has been successfully executed on the main branch with Ruby 3.4 in the matrix, confirming compatibility with the ubuntu-latest runner. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check if the workflow has been run successfully with Ruby 3.4
gh run list --workflow=test-linux-ruby.yml --json conclusion,headBranch,status --jq '.[] | select(.headBranch=="main" or .headBranch=="refs/heads/main") | select(.status=="completed") | .conclusion' | head -n 1
Length of output: 220 .github/workflows/test-darwin-ruby.yml (1)
The addition of Ruby 3.4 with macos-latest runner is correct and maintains consistency with:
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit