[TRAH] shontzu/TRAH-2643/MT5PasswordModal-improvement #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/TRAH-2643/MT5PasswordModal-improvement-2
…/TRAH-2643/MT5PasswordModal-improvement-2
…shontzu/TRAH-2643/improvement-3
shontzu-deriv
force-pushed
the
shontzu/TRAH-2643/MT5PasswordModal-improvement-3
branch
from
00cb0a4
to
6882623
Compare
hamza-deriv
suggested changes
Jan 16, 2024
| password, | ||
| marketType, | ||
| activeTrading, | ||
| mutate, |
There was a problem hiding this comment.
tradingPasswordChange,
mutate,
activeTrading,
settings,
These are coming from deriv/api so we can directly call them here instead of passing props
| selectedJurisdiction, | ||
| availableMT5Accounts | ||
| ) => { | ||
| const accountType = marketType === MarketType.SYNTHETIC ? 'gaming' : marketType; |
There was a problem hiding this comment.
Can use constant file here for gaming but its upto you
Its a small nit but it is hardcoded value
|
|
||
| // in order to create account, we need to set a password through trading_platform_password_change endpoint first | ||
| // then only mt5_create_account can be called, otherwise it will response an error for password required | ||
| if (isMT5PasswordNotSet) { |
…643/MT5PasswordModal-improvement-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
split massive
MT5PasswordModalfile into smaller componentsScreenshots: