Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address PytestUnknownMarkWarning #31

Merged

Conversation

miketheman
Copy link
Contributor

As of pytest 4.5.0, a new warning is raised when the plugin doesn't
register its markers. See pytest-dev/pytest#5177

The docs recommend registering custom markers:
https://docs.pytest.org/en/latest/writing_plugins.html#registering-markers

Signed-off-by: Mike Fiedler miketheman@gmail.com

As of pytest 4.5.0, a new warning is raised when the plugin doesn't
register its markers. See pytest-dev/pytest#5177

The docs recommend registering custom markers:
https://docs.pytest.org/en/latest/writing_plugins.html#registering-markers

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman
Copy link
Contributor Author

The marker is now available via pytest --markers:

$ tox -e py37 -- --markers | grep black
...
@pytest.mark.black: enable format checking with black

@jaraco jaraco mentioned this pull request May 15, 2019
Copy link

@paddycarey paddycarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddycarey
Copy link

I'll get this shipped later tonight

@miketheman
Copy link
Contributor Author

@paddycarey Anything I can do to help this along?

@paddycarey paddycarey merged commit 4a411c9 into shopkeep:master May 28, 2019
@miketheman miketheman deleted the miketheman/pytest-deprecation-warning branch May 28, 2019 18:19
@miketheman
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants