Fix decoding of .0 #137
Merged
Fix decoding of .0 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since trailing 0 digits after the decimal point are trimmed, intString becomes an empty string when there is no digit before the decimal point and all digits after the decimal point is 0, causing big.Int SetString to fail because there is no string to parse. Fix shopspring#134.
flemeur
pushed a commit
to flemeur/decimal
that referenced
this pull request
Nov 5, 2019
Fix decoding of .0
fairyhunter13
added a commit
to fairyhunter13/decimal
that referenced
this pull request
Jul 12, 2020
Fix decoding of .0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since trailing 0 digits after the decimal point are trimmed, intString
becomes an empty string when there is no digit before the decimal point
and all digits after the decimal point is 0, causing big.Int SetString
to fail because there is no string to parse.
Fix #134.