Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-39412 - Use common PHPStan config from core #50

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

mitelg
Copy link
Member

@mitelg mitelg commented Dec 2, 2024

No description provided.

@cyl3x
Copy link
Contributor

cyl3x commented Dec 2, 2024

Looks good, regarding the failing minimum workflow: I think we should move the change in a separate file and load/copy the correct one in bin/phpstan-config-generator.php

@mitelg mitelg force-pushed the next-39412/update-phpstan branch from 55c85d0 to e3088d4 Compare December 2, 2024 13:26
@mitelg
Copy link
Member Author

mitelg commented Dec 2, 2024

found another solution, which is also okay 👍

@mitelg mitelg force-pushed the next-39412/update-phpstan branch from e3088d4 to c314e10 Compare December 2, 2024 13:37
@mitelg mitelg self-assigned this Dec 2, 2024
@mitelg mitelg merged commit bfb20cd into trunk Dec 2, 2024
20 checks passed
@mitelg mitelg deleted the next-39412/update-phpstan branch December 2, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants