Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_if_shop_url_is_reachable fails when shop is in maintenance mode #55

Closed
MoritzKrafeld opened this issue Jan 15, 2025 · 0 comments · Fixed by #56
Closed

check_if_shop_url_is_reachable fails when shop is in maintenance mode #55

MoritzKrafeld opened this issue Jan 15, 2025 · 0 comments · Fixed by #56
Labels
bug Something isn't working

Comments

@MoritzKrafeld
Copy link
Member

The configuration option check_if_shop_url_is_reachable fails when the shop is in maintenance mode even though the API of the shop is still available.
The check itself fails because it is being redirected from my-app-url.com to my-app-url.com/maintenance (HTTP 307). Even if we would allow multiple redirects (as this one is only a temporary and not a permanent redirect), it would still fail because the my-app-url.com/maintenance request responds with a HTTP 503 Service Unavailable.
A possible solution could be to check if certain API routes are available and do not return a redirect (3xx) and also no internal server error (5xx).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant