fix: check if api is reachable during registration #56
Conversation
MoritzKrafeld
requested review from
fschmtt,
shyim,
adrianles and
SebastianFranze
| @@ -33,7 +33,7 @@ public function __invoke(BeforeRegistrationStartsEvent $event): void | |||
| $shop = $event->getShop(); | |||
|
|
|||
| try { | |||
| $this->httpClient->request('HEAD', $shop->getShopUrl(), [ | |||
| $this->httpClient->request('HEAD', sprintf("%s/api/_info/config", $shop->getShopUrl()), [ | |||
There was a problem hiding this comment.
the problem with that is that we get always a 401 🤔. is that fine. @nsaliu
There was a problem hiding this comment.
Not in this case when we do a HEAD instead of POST request 😄
There was a problem hiding this comment.
Sorry, POST is not allowed but even a GET would return a HTTP 200 with the 401 error in the payload 🙈
But a HEAD does also return a 200 without any response body and also no error 😄
There was a problem hiding this comment.
Thanks to our awesome community! 😄
There was a problem hiding this comment.
But a HEAD does also return a 200 without any response body and also no error
Are you sure about that 🤔
When I try e.g. curl --head http://localhost:8000/api/_info/config, i am always getting 401 😬
How did you tried that?
There was a problem hiding this comment.
Hmm you're right. I'm also getting 401 as a response. I tried this is a few APP_URL's of our customers and never had the problem with that and always got the 200 back 🙈
I will create a PR so that we also allow 401 (or something which would indicate us that the server is reachable) 😅
There was a problem hiding this comment.
Should hopefully be fixed in this PR: #58
mitelg
deleted the
fix-55/check-shop-url-is-reachable-in-maintenance-mode
branch
Fixes #55
During registration, we check if the API is reachable instead of just the
APP_URLbecause this could also be mapped to a sales channel which is currently in maintenance mode.