fix: trim trailing slashes in shop url in before registration start l… #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoritzKrafeld
requested review from
nsaliu,
fschmtt,
shyim,
adrianles and
SebastianFranze
nsaliu
approved these changes
Jan 16, 2025
|
If this gets merged (shopware/app-php-sdk#36) we don't need this MR anymore 😄 |
|
Not needed anymore as this is already fixed in https://github.com/shopware/app-php-sdk/releases/tag/4.0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a trailing slash in the app url during registration, we need to trim it in order to check if the shop is reachable. This has already been fixed in the app php sdk so that can't happen anymore after the registration is done. As this could still happen during registration and the event which we get contains the whole request, we need to trim it at this point. Trimming it before this would result in an inconsistency between the URL in
$event->getRequest()and$event->getShop()->getShopUrl().