NEXT-39504 - Sanitize the Shop URL during the registration process #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
reviewed
Nov 12, 2024
nsaliu
force-pushed
the
next-39504/sanitize-shop-url-during-the-registration-process
branch
from
18d34a1 to
fd15027
Compare
shyim
approved these changes
Nov 18, 2024
shyim
deleted the
next-39504/sanitize-shop-url-during-the-registration-process
branch
nsaliu
pushed a commit
that referenced
this pull request
Nov 25, 2024
…ing-the-registration-process NEXT-39504 - Sanitize the Shop URL during the registration process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering a new Shop with the App system, we need to sanitize the Shop URL by removing at least the trailing slash.
In this PR, I'm removing the trailing slash and also doing URL sanitization in general.