Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redirect error handling in HTTP client #22

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

shyim
Copy link
Member

@shyim shyim commented Nov 18, 2024

No description provided.

@fschmtt fschmtt self-requested a review November 18, 2024 14:07
@shyim shyim merged commit 837d204 into main Nov 18, 2024
2 checks passed
@shyim shyim deleted the error-on-redirect-on-api-client branch November 18, 2024 14:08
@thuanlv287
Copy link
Contributor

Hi @shyim
I tried to hit the action button in admin. The error occurs from
const entitySearchResult = await repository.search(new Criteria(ctx.payload.data.ids));

It says:
✘ [ERROR] TypeError: Invalid redirect value must be one of "follow" or "manual" ("error" won't be implemented since it does not make sense at the edge; use "manual" and check the response status code).

How should I deal with this one?

@shyim
Copy link
Member Author

shyim commented Nov 23, 2024

Which runtime are you using?

@thuanlv287
Copy link
Contributor

I'm using Cloudflare worker with the latest verison @shopware-ag/app-server-sdk (1.1.10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants