Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error handling #1620

Merged
merged 4 commits into from
Jan 22, 2025
Merged

feat: improve error handling #1620

merged 4 commits into from
Jan 22, 2025

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Jan 22, 2025

Description

Improved error handling to display proper error page on API errors.

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Jan 22, 2025 0:56am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jan 22, 2025 0:56am

Copy link

pkg-pr-new bot commented Jan 22, 2025

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1620

@shopware/cms-base-layer

npm i https://pkg.pr.new/shopware/frontends/@shopware/cms-base-layer@1620

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1620

@shopware/nuxt-module

npm i https://pkg.pr.new/shopware/frontends/@shopware/nuxt-module@1620

@shopware/composables

npm i https://pkg.pr.new/shopware/frontends/@shopware/composables@1620

@shopware/helpers

npm i https://pkg.pr.new/shopware/frontends/@shopware/helpers@1620

commit: c9adce5

Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #1620 will not alter performance

Comparing feat/improve-error-handling (c9adce5) with main (541cd6e)

Summary

✅ 9 untouched benchmarks

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 🏃🏼

@patzick patzick merged commit 7f000d1 into main Jan 22, 2025
13 of 14 checks passed
@patzick patzick deleted the feat/improve-error-handling branch January 22, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants