Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Embed docs to DevHub #493

Closed
wants to merge 1 commit into from
Closed

chore(docs): Embed docs to DevHub #493

wants to merge 1 commit into from

Conversation

bojanrajh
Copy link
Contributor

@bojanrajh bojanrajh commented Dec 6, 2023

Description

This PR cleans up this repo for embedding frontends info developer-portal - shopware/developer-portal#128

Type of change

ToDo's

  • removed @shopware-pwa/typer private package, moved it to @shopware-docs/typer (now public/published)
  • cleaned up apps/docs folder
  • added shortcuts to package.json - docs:env, docs:link and docs:preview
  • added DevHub workflows for previewing and deploying changes
  • static sidebar
  • fixed deadlinks, added missing files
  • kept package.json
  • set up DEV_HUB_PERSONAL_ACCESS_TOKEN secret
  • deactivate Vercel integration

Screenshots

Additional context

@bojanrajh bojanrajh added the documentation Improvements or additions to documentation label Dec 6, 2023
Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Jul 5, 2024 8:47am
shopware-frontends-docs ❌ Failed (Inspect) Jul 5, 2024 8:47am

@bojanrajh bojanrajh changed the title Dx devhub chore(docs): Embed docs to DevHub Dec 6, 2023
Copy link

codspeed-hq bot commented Feb 16, 2024

CodSpeed Performance Report

Merging #493 will not alter performance

Comparing DX-devhub (a8f4588) with main (f9d2735)

Summary

✅ 9 untouched benchmarks

@BrocksiNet
Copy link
Collaborator

What is missing? Can we somehow support it? Asking for a friend.

@bojanrajh
Copy link
Contributor Author

What is missing? Can we somehow support it? Asking for a friend.

I'll rebase, sync the typer package, then we can talk about the new docs workflow. You can still use your old (isolated) and new (embedded) workflows, and this branch is already published to prod (though not linked in the menu, it is searchable by Algolia and contents are provided to the Copilot AI).

feat: remove typer

feat: cleanup vitepress theme

feat: extract sidebar

feat: after-install scripts

feat: pass wd

feat: add shortcuts

fix: deadlinks

feat: add missing articles

feat: keep source when symlinking

feat: revert package.json

feat: cleanup

vercel

fix: build

fix: logo

feat: algolia

feat: remove typer
@bojanrajh
Copy link
Contributor Author

@BrocksiNet This was rebased, but generated API references are not working on prod because of the new plugin structure. We'll need to adapt that on our end.

@BrocksiNet
Copy link
Collaborator

@BrocksiNet This was rebased, but generated API references are not working on prod because of the new plugin structure. We'll need to adapt that on our end.

Thx @bojanrajh 🙌 Great work.

We discussed updating our docs to the newest Vitepress version (see).
Do you see any problem with that? 😀

@bojanrajh
Copy link
Contributor Author

Technically, you could see changes in theme.json and package.json in this branch. You can also use clean version of config.ts (because config is already in baseConfig (and sidebar.ts). Keep your plugin definition and you should be good with your standalone docs.

This branch already includes the latest version, but there are 2 breaking changes: API reference (though, it should be properly generated in the standalone version, but not in the DevHub context) and local search (replaced with algolia). Along with possible minor CSS changes from past months (I did apply some stuff from this repo into the theme already).

@bojanrajh
Copy link
Contributor Author

Closing in favour of #1313, #1327 and #1337.

@bojanrajh bojanrajh closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants