build(deps-dev): bump eslint from 8.57.0 to 9.18.0

examples/admin-sdk-app/package.json

@@ -32,7 +32,7 @@
     "@types/node": "^18.19.19",
     "@typescript-eslint/eslint-plugin": "^5.62.0",
     "@typescript-eslint/parser": "^5.62.0",
-    "eslint": "^8.57.0",
+    "eslint": "^9.18.0",
     "eslint-plugin-vue": "^9.22.0",
     "nodemon": "^2.0.22",
     "ts-node": "^10.9.2",

examples/admin-sdk-plugin/tests/acceptance/eslint.config.mjs

@@ -0,0 +1,55 @@
+import typescriptEslint from "@typescript-eslint/eslint-plugin";
+import tsParser from "@typescript-eslint/parser";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+import eslintConfigPrettier from "eslint-config-prettier";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+});
+
+export default [
+  ...compat.extends(
+    "eslint:recommended",
+    "plugin:@typescript-eslint/recommended",
+    "plugin:playwright/recommended"
+  ),
+  {
+    plugins: {
+      "@typescript-eslint": typescriptEslint,
+    },
+
+    languageOptions: {
+      parser: tsParser,
+    },
+
+    rules: {
+      quotes: [
+        "error",
+        "single",
+        {
+          allowTemplateLiterals: true,
+        },
+      ],
+
+      "no-console": [
+        "error",
+        {
+          allow: ["warn", "error"],
+        },
+      ],
+
+      "comma-dangle": ["error", "always-multiline"],
+      "no-unused-vars": "warn",
+      "@typescript-eslint/no-unused-vars": "warn",
+      "playwright/expect-expect": "off",
+    },
+  },
+  eslintConfigPrettier,
+];

examples/admin-sdk-plugin/tests/acceptance/package.json

@@ -10,7 +10,7 @@
   "main": "index.js",
   "scripts": {
     "format": "prettier ./tests --write",
-    "lint:eslint": "eslint . --ext .ts",
+    "lint:eslint": "eslint ./tests ./fixtures",
     "lint:fix": "eslint . --ext .ts --fix",
     "test:ats": "playwright test",
     "test:ats:dev": "playwright test --ui"
@@ -19,12 +19,14 @@
     "@shopware-ag/acceptance-test-suite": "^3.8.4"
   },
   "devDependencies": {
+    "@eslint/eslintrc": "^3.2.0",
+    "@eslint/js": "^9.18.0",
     "@playwright/test": "^1.45.0",
     "@types/node": "^22.5.5",
-    "@typescript-eslint/eslint-plugin": "^5.47.0",
-    "@typescript-eslint/parser": "^5.47.0",
-    "eslint": "^8.49.0",
-    "eslint-plugin-playwright": "^1.6.2",
+    "@typescript-eslint/eslint-plugin": "^8.21.0",
+    "@typescript-eslint/parser": "^8.21.0",
+    "eslint": "^9.18.0",
+    "eslint-plugin-playwright": "^2.1.0",
     "prettier": "3.3.3"
   }
 }

packages/admin-sdk/package.json

@@ -99,7 +99,7 @@
     "@typescript-eslint/parser": "^5.47.0",
     "chokidar-cli": "^3.0.0",
     "concurrently": "^7.0.0",
-    "eslint": "^8.11.0",
+    "eslint": "^9.18.0",
     "eslint-plugin-check-file": "^2.7.0",
     "eslint-plugin-import": "^2.31.0",
     "flush-promises": "^1.0.2",

packages/component-library/package.json

@@ -106,7 +106,7 @@
     "@vue/eslint-config-typescript": "^12.0.0",
     "@vue/test-utils": "^2.4.2",
     "@vue/tsconfig": "^0.4.0",
-    "eslint": "^8.49.0",
+    "eslint": "^9.18.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-storybook": "^0.11.1",
     "eslint-plugin-vitest": "^0.3.20",

packages/icon-kit/package.json

@@ -51,7 +51,7 @@
     "axios": "^0.26.1",
     "chalk": "^4.1.2",
     "cli-progress": "^3.10.0",
-    "eslint": "^8.12.0",
+    "eslint": "^9.18.0",
     "eslint-plugin-import": "^2.31.0",
     "fs-extra": "^10.0.1",
     "svgo": "^2.8.0",

packages/tokens/eslint.config.js

@@ -0,0 +1,100 @@
+/* eslint-disable */
+import typescriptEslint from '@typescript-eslint/eslint-plugin';
+import tsParser from '@typescript-eslint/parser';
+import vitest from 'eslint-plugin-vitest';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import js from '@eslint/js';
+import { FlatCompat } from '@eslint/eslintrc';
+import tseslint from 'typescript-eslint';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+});
+
+export default tseslint.config([
+  ...compat.extends(
+    'eslint:recommended',
+    'plugin:@typescript-eslint/strict-type-checked',
+  ),
+  {
+    plugins: {
+      '@typescript-eslint': typescriptEslint,
+    },
+
+    languageOptions: {
+      parser: tsParser,
+      ecmaVersion: 5,
+      sourceType: 'script',
+
+      parserOptions: {
+        project: true,
+        tsconfigRootDir: '/workspaces/meteor/packages/tokens',
+      },
+    },
+
+    rules: {
+      '@typescript-eslint/no-unused-vars': [
+        'warn',
+        {
+          argsIgnorePattern: '^_',
+        },
+      ],
+    },
+  },
+  {
+    files: ['**/*.test.ts'],
+
+    plugins: {
+      vitest,
+    },
+
+    rules: {
+      'vitest/expect-expect': 'error',
+      'vitest/no-alias-methods': 'error',
+      'vitest/no-commented-out-tests': 'error',
+      'vitest/no-conditional-expect': 'error',
+      'vitest/no-conditional-in-test': 'error',
+      'vitest/no-conditional-tests': 'error',
+      'vitest/no-disabled-tests': 'error',
+      'vitest/no-duplicate-hooks': 'error',
+      'vitest/no-identical-title': 'error',
+      'vitest/no-import-node-test': 'error',
+      'vitest/no-interpolation-in-snapshots': 'error',
+      'vitest/no-large-snapshots': 'error',
+      'vitest/no-mocks-import': 'error',
+      'vitest/no-standalone-expect': 'error',
+      'vitest/no-test-prefixes': 'error',
+      'vitest/no-test-return-statement': 'error',
+      'vitest/prefer-called-with': 'error',
+      'vitest/prefer-comparison-matcher': 'error',
+      'vitest/prefer-each': 'error',
+      'vitest/prefer-equality-matcher': 'error',
+      'vitest/prefer-expect-resolves': 'error',
+      'vitest/prefer-hooks-in-order': 'error',
+      'vitest/prefer-hooks-on-top': 'error',
+      'vitest/prefer-mock-promise-shorthand': 'error',
+      'vitest/prefer-strict-equal': 'error',
+      'vitest/prefer-to-be': 'error',
+      'vitest/prefer-to-contain': 'error',
+      'vitest/prefer-to-have-length': 'error',
+      'vitest/prefer-todo': 'error',
+      'vitest/require-local-test-context-for-concurrent-snapshots': 'error',
+      'vitest/valid-describe-callback': 'error',
+      'vitest/valid-expect': 'error',
+
+      'vitest/valid-title': [
+        'error',
+        {
+          ignoreTypeOfDescribeName: false,
+          allowArguments: false,
+          disallowedWords: ['should'],
+        },
+      ],
+    },
+  },
+]);

packages/tokens/package.json

@@ -38,14 +38,18 @@
     "zod": "^3.22.4"
   },
   "devDependencies": {
+    "@eslint/eslintrc": "^3.2.0",
+    "@eslint/js": "^9.18.0",
     "@types/node": "^20.11.8",
-    "@typescript-eslint/eslint-plugin": "^6.19.1",
-    "@typescript-eslint/parser": "^6.19.1",
-    "eslint": "^8.56.0",
-    "eslint-plugin-vitest": "^0.3.20",
+    "@typescript-eslint/eslint-plugin": "^8.21.0",
+    "@typescript-eslint/parser": "^8.21.0",
+    "eslint": "^9.18.0",
+    "eslint-plugin-vitest": "^0.5.4",
     "msw": "^2.1.5",
     "prettier": "^3.2.4",
     "style-dictionary": "^3.9.2",
-    "tsx": "^4.7.0"
+    "tsx": "^4.7.0",
+    "typescript-eslint": "^8.21.0",
+    "eslint-config-prettier": "^10.0.1"
   }
 }

packages/tokens/src/common/domain/utils/object.ts

@@ -1,7 +1,7 @@
-export function set<TValue>(
+export function set(
   target: Record<string, unknown>,
   path: string,
-  value: TValue,
+  value: unknown,
 ) {
   const keys = path.split('.');
   let currentObj = target;

packages/tokens/src/common/infrastructure/file-system/HardDiskFileSystem.test.ts

@@ -4,10 +4,10 @@ import fs from 'node:fs';
 import path from 'node:path';
 
 function cleanUp(pathToFile: string) {
-  fs.existsSync(pathToFile) && fs.unlinkSync(pathToFile);
+  if (fs.existsSync(pathToFile)) fs.unlinkSync(pathToFile);
 
   const directory = path.join(__dirname, './artifact');
-  fs.existsSync(directory) && fs.rmdirSync(directory);
+  if (fs.existsSync(directory)) fs.rmdirSync(directory);
 }
 
 test('creates a file that did not exist before', () => {

packages/tokens/src/deliverable/domain/CSSDeliverable.ts

@@ -46,10 +46,10 @@ export class CSSDeliverable implements Deliverable {
 
         if (typeof resolvedValue === 'number') {
           if (!variableName.includes('weight')) {
-            return `--${variableName}: ${resolvedValue / 16}rem;`;
+            return `--${variableName}: ${String(resolvedValue / 16)}rem;`;
           }
 
-          return `--${variableName}: ${resolvedValue};`;
+          return `--${variableName}: ${resolvedValue.toString()};`;
         }
 
         return `--${variableName}: '${resolvedValue}';`;

packages/tokens/tsconfig.json

@@ -31,7 +31,7 @@
     "lib": ["es2022"]
   },
   "include": [
-    "./.eslintrc.cjs",
+    "./eslint.config.js",
     "./vitest.setup.ts",
     "./vitest.config.ts",
     "src",