Improve colorpicker accessibility #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
test: add unit tests revert css to scss add css focus classes update snapshots Add changeset
alastair-simon
force-pushed
the
improve-colorpicker-accessibility
branch
from
2557906 to
6a86ae2
Compare
Haberkamp
approved these changes
Jan 21, 2025
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-tokens
@shopware-ag/meteor-icon-kit
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve the accessibility of the mt-colorpicker component
Why?
Currently the colorpicker does not allow focus tabbing for navigation, making it in-accessable for users without a cursor.
How?
Using the Focus-trap dependancy to allow focus navigation inside the colorpicker modal
Testing?
I've added some unit tests to ensure the tabbing is working correctly