Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next 37781 - Fix quotes from scripts + prepare v0.8.0 #34

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

MalteJanz
Copy link
Contributor

Fixes wrongly set quotation around string values passed out of scripts

Copy link

Summary of the total line code coverage for the whole codebase

Total lines Covered Skipped % (pr) % (main)
2024 1132 892 55.93 55.98
Summary of each file (click to expand)
File Total lines Covered Skipped %
src/api/filter.rs 171 168 3 98.25
src/api/mod.rs 369 62 307 16.80
src/cli.rs 45 31 14 68.89
src/config_file.rs 76 56 20 73.68
src/data/export.rs 136 0 136 0.00
src/data/import.rs 162 0 162 0.00
src/data/transform/mod.rs 336 259 77 77.08
src/data/transform/script.rs 292 258 34 88.36
src/data/validate.rs 298 298 0 100.00
src/main.rs 139 0 139 0.00
More details (click to expand)

Download full HTML report

You can download the full HTML report here: click to download
Hint: You need to extract it locally and open the index.html, there you can see which lines are not covered in each file.

You can also generate these reports locally

For that, you need to install cargo-llvm-cov, then you can run:

cargo llvm-cov --all-features --no-fail-fast --open

Hint: There are also other ways to see code coverage in Rust. For example with RustRover, you can execute tests with coverage generation directly in the IDE.

Remember

Your tests should be meaningful and not just be written to raise the coverage.
Coverage is just a tool to detect forgotten code paths you may want to think about, not your instructor to write tests

@MalteJanz MalteJanz self-assigned this Aug 20, 2024
@MalteJanz MalteJanz added the bug Something isn't working label Aug 20, 2024
@MalteJanz MalteJanz marked this pull request as ready for review August 20, 2024 15:02
@MalteJanz MalteJanz merged commit b44da1d into main Aug 20, 2024
3 checks passed
@MalteJanz MalteJanz deleted the next-37781/fix-quotes-from-scripts branch August 20, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants