Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "SYS_KEYS has no physical keys " error on preview #2646

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: "SYS_KEYS has no physical keys " error on preview #2646

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
244c537
fix: "SYS_KEYS has no physical keys " error on preview
elliots Nov 27, 2024
543df03
Merge branch 'main' into fix/sys_keys_error
eseidel Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/shorebird_cli/lib/src/executables/adb.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
if (deviceId != null) ...['-s', deviceId],
'shell',
'monkey',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so confused why we're using monkey at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I guess that's a known way. I'm used to historically sending an intent: https://www.repeato.app/launching-android-applications-via-adb/

'--pct-syskeys 0',

Check warning on line 54 in packages/shorebird_cli/lib/src/executables/adb.dart

View workflow job for this annotation

GitHub Actions / 🔤 Check Spelling / build 

Unknown word (syskeys)
'-p $package',
'1',
];
Expand Down
Loading