New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buffers): compute width before creating sides #397

Merged

shortcuts merged 1 commit into main from fix/pre-compute-width

Sep 23, 2024

Owner

shortcuts commented Sep 23, 2024 •

edited

Loading

📃 Summary

we should pre-compute the side width, otherwise when computing right, left will already be there and make the computing off by left's width

closes #396


          fix(buffers): compute width before creating sides

703d9fb

shortcuts self-assigned this

shortcuts merged commit 3f69467 into main

6 checks passed

shortcuts deleted the fix/pre-compute-width branch

September 23, 2024 20:08

github-actions bot mentioned this pull request

chore(main): release 2.0.3 #398

Merged

shortcuts pushed a commit that referenced this pull request


          chore(main): release 2.0.3 (#398)

73494b3

🤖 I have created a release *beep* *boop*
---


##
[2.0.3](v2.0.2...v2.0.3)
(2024-09-23)


### Bug Fixes

* **buffers:** compute width before creating sides
([#397](#397))
([3f69467](3f69467))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet