Create a Nested version of the css-vars mixin #2
Conversation
Allow the css vars to be natively namespaced.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "css-var", | |||
| "version": "2.1.1", | |||
| "name": "css-vars", | |||
There was a problem hiding this comment.
The name is already taken in bower, so it was not a typo, it was on purpose
|
Hey @RedLucas That's why I'm not sure this addition will not provide additional unexpected behavior. |
|
I also get the concern regarding unexpected behavior, though I am using this and so far I've been happy with it. I need it to work like this for a project I'm working on, though I could always just use my fork... I'd prefer to contribute it back into this project if that's possible. Just need to keep using this thing until Microsoft drops support for IE11, then maybe we can ascend to a greater state of being. |
| /// | ||
| @mixin css-vars($varMap: null) { | ||
| // CHECK PARAMS | ||
| @mixin _css-vars($varMap: null) { |
There was a problem hiding this comment.
In this case better to exclude the CHECK_PARAMS part and call the new mixin differently to reflect it
| // )); | ||
| /// | ||
| @mixin css-vars-nested($varMap: null) { |
There was a problem hiding this comment.
The mixins css-vars and and css-vars-nested are the same,
except the parts "@at-root :root {" and "& {" - please consider extending that to follow the DRY
There was a problem hiding this comment.
Can you please update the mixins comments to reflect the difference between them
There was a problem hiding this comment.
And the last one- with such an update README should be changed with the provided addition
| // )); | ||
| /// | ||
| @mixin css-vars-nested($varMap: null) { |
There was a problem hiding this comment.
Can you consider adding tests for this as well
|
Closing as the PR is not mergable and not updated for a year. |
The idea of this is to allow you to apply variables in a nested context. So you can apply variables to a class, and not global. I couldn't think of a way to detect if we are root already so I made a second function and tried to take out the stuff from both and put it into its own function.
Let me know what you think, but I think this is pretty cool.