Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster: improve message naming #1787

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 28, 2024

Where possible we should avoid the variable name message instead use either request or response. This makes the code easier to read since it gives more context to the type of message being stored.

Copy link

codspeed-hq bot commented Oct 28, 2024

CodSpeed Performance Report

Merging #1787 will not alter performance

Comparing rukai:prefer_request_naming (8c3faba) with main (487ffec)

Summary

✅ 38 untouched benchmarks

@rukai rukai force-pushed the prefer_request_naming branch from 4a511dd to 1ecf2ee Compare October 28, 2024 22:56
@rukai rukai merged commit 9b845ef into shotover:main Oct 29, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants