Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis-protocol and other crates #1855

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Dec 3, 2024

Since #1854 is blocked on upstream and we have not heard back, lets continue with the upgrade but leave out scylla-rust-driver.

Crates requiring changes to shotover/tests:

@rukai rukai force-pushed the update_redis_protocol branch 2 times, most recently from 0397952 to 2ad6e9f Compare December 3, 2024 05:40
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #1855 will not alter performance

Comparing rukai:update_redis_protocol (1a9c658) with main (ad8bc50)

Summary

✅ 38 untouched benchmarks

@rukai rukai force-pushed the update_redis_protocol branch from 2ad6e9f to 1a9c658 Compare December 3, 2024 22:03
@justinweng-instaclustr
Copy link
Collaborator

Since #1854 is blocked on upstream and we have not heard back, lets continue with the upgrade but leave out scylla-rust-driver.

Did you mean #1840?

@rukai
Copy link
Member Author

rukai commented Dec 3, 2024

yep, my mistake, I meant #1840

@rukai rukai merged commit 21a0ff7 into shotover:main Dec 3, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants